Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Unified Diff: chrome/browser/prerender/prerender_browsertest.cc

Issue 2616383002: Prerender: avoid race condition with canceling prerender in test. (Closed)
Patch Set: remove unused test file fetch complexity Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prerender/prerender_browsertest.cc
diff --git a/chrome/browser/prerender/prerender_browsertest.cc b/chrome/browser/prerender/prerender_browsertest.cc
index 21dbd851946e30f755e89b972ed6c399cd06af02..b121fa6c19f8bc88357b7ef0029fa8efd7b3b442 100644
--- a/chrome/browser/prerender/prerender_browsertest.cc
+++ b/chrome/browser/prerender/prerender_browsertest.cc
@@ -3294,10 +3294,16 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, FirstContentfulPaintTimingReuse) {
base::SimpleTestTickClock* clock = OverridePrerenderManagerTimeTicks();
GURL url = embedded_test_server()->GetURL("/prerender/prerender_page.html");
+ base::RunLoop hanging_request_waiter;
+ BrowserThread::PostTask(BrowserThread::IO, FROM_HERE,
+ base::Bind(&CreateHangingFirstRequestInterceptorOnIO,
+ url, GetTestPath("prerender_page.html"),
+ hanging_request_waiter.QuitClosure()));
// As this load will be canceled, it is not waited for, and hence no
// javascript is executed.
DisableJavascriptCalls();
PrerenderTestURL(url, FINAL_STATUS_CANCELLED, 0);
+ hanging_request_waiter.Run();
// This prerender cancels and reuses the first.
clock->Advance(base::TimeDelta::FromSeconds(1));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698