Move browser_test_runner.LoadAllTestsInModule to serially_executed_browser_test_case

Move browser_test_runner.LoadAllTestsInModule to serially_executed_browser_test_case

This also adds call to LoadAllTestsInModule for the load_tests method to the 
examples in telemetry/examples/.

Motivation: to migrate the core test_runner in  browser_test_runner, we need to 
make sure that typ can execute the code that generate the test case in the 
subprocesses.

BUG=chromium:636153
Review-Url: https://codereview.chromium.org/2562913003
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/670692248ead326cac18ed0eb4931cf3f27a5961

[nednguyen, 2016-12-09 21:21:00]

Description was changed from

==========
Refactor the browser_test_runner code

BUG=chromium:636153
==========

to

==========
Move browser_test_runner.LoadAllTestsInModule to
serially_executed_browser_test_case

This also adds call to LoadAllTestsInModule for the load_tests method to the 
examples in telemetry/examples/.

As a result of this, telemetry/examples/run_generated_tests_with_typ should be
able to pick up all the tests to be run.

BUG=chromium:636153
==========

[nednguyen, 2016-12-09 21:21:00]

nednguyen@google.com changed reviewers:
+ dpranke@chromium.org, kbr@chromium.org

[nednguyen, 2016-12-09 21:22:24]

On 2016/12/09 21:21:07, nednguyen wrote:

This CL is not ready to land yet, there are error with
telemetry/examples/run_generated_tests_with_typ:

./telemetry/examples/run_generated_tests_with_typ
simple_numeric_test.load_tests() failed: 'NoneType' object has no attribute
'adder_sum'


Not sure how debug this since typ doesn't report the line number of the
exception. +Dirk

[nednguyen, 2016-12-09 21:24:04]

Description was changed from

==========
Move browser_test_runner.LoadAllTestsInModule to
serially_executed_browser_test_case

This also adds call to LoadAllTestsInModule for the load_tests method to the 
examples in telemetry/examples/.

As a result of this, telemetry/examples/run_generated_tests_with_typ should be
able to pick up all the tests to be run.

BUG=chromium:636153
==========

to

==========
Move browser_test_runner.LoadAllTestsInModule to
serially_executed_browser_test_case

This also adds call to LoadAllTestsInModule for the load_tests method to the 
examples in telemetry/examples/.

As a result of this, telemetry/examples/run_generated_tests_with_typ should be
able to pick up all the tests to be run.

Motivation: to migrate the core test_runner in  browser_test_runner, we need to 
make sure that typ can execute the code that generate the test case in the 
subprocesses.

BUG=chromium:636153
==========

[nednguyen, 2016-12-09 22:00:36]

On 2016/12/09 21:22:24, nednguyen wrote:
> On 2016/12/09 21:21:07, nednguyen wrote:
> 
> This CL is not ready to land yet, there are error with
> telemetry/examples/run_generated_tests_with_typ:
> 
> ./telemetry/examples/run_generated_tests_with_typ
> simple_numeric_test.load_tests() failed: 'NoneType' object has no attribute
> 'adder_sum'
> 
> 
> Not sure how debug this since typ doesn't report the line number of the
> exception. +Dirk

NVM, I figured out the reason why run_generated_tests_with_typ didn't work. That
was because it did not set up the global option object, but
telemetry/telemetry/testing/browser_test_runner.py will. This CL is now ready
for review, PTAL

[nednguyen, 2016-12-09 22:02:13]

Description was changed from

==========
Move browser_test_runner.LoadAllTestsInModule to
serially_executed_browser_test_case

This also adds call to LoadAllTestsInModule for the load_tests method to the 
examples in telemetry/examples/.

As a result of this, telemetry/examples/run_generated_tests_with_typ should be
able to pick up all the tests to be run.

Motivation: to migrate the core test_runner in  browser_test_runner, we need to 
make sure that typ can execute the code that generate the test case in the 
subprocesses.

BUG=chromium:636153
==========

to

==========
Move browser_test_runner.LoadAllTestsInModule to
serially_executed_browser_test_case

This also adds call to LoadAllTestsInModule for the load_tests method to the 
examples in telemetry/examples/.

Motivation: to migrate the core test_runner in  browser_test_runner, we need to 
make sure that typ can execute the code that generate the test case in the 
subprocesses.

BUG=chromium:636153
==========

[Ken Russell (switch to Gerrit), 2016-12-09 22:09:41]

Awesome work Ned. Thanks for working on this. LGTM

Do I understand correctly that we'll need to add load_tests functions to all the
GPU integration tests as this is rolled in?

[nednguyen, 2016-12-09 22:11:12]

On 2016/12/09 22:09:41, Ken Russell wrote:
> Awesome work Ned. Thanks for working on this. LGTM
> 
> Do I understand correctly that we'll need to add load_tests functions to all
the
> GPU integration tests as this is rolled in?

Not yet. But you can add it so that when I change the test runner to typ, the
roll won't be blocked.

[nednguyen, 2016-12-09 22:11:18]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2016-12-09 22:11:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 22:15:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 22:15:14]

Try jobs failed on following builders:
  Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Ma...)

[nednguyen, 2016-12-10 00:16:15]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2016-12-10 00:16:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 00:31:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 00:31:13]

Try jobs failed on following builders:
  Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Ma...)

[nednguyen, 2016-12-10 00:36:30]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2016-12-10 00:36:30]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2562913003/#ps40001
(title: "Fix test")

[commit-bot: I haz the power, 2016-12-10 00:36:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 01:37:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 01:37:45]

Try jobs failed on following builders:
  Catapult Linux Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Li...)

[nednguyen, 2016-12-10 02:08:53]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2016-12-10 02:09:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 03:10:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 03:10:09]

Try jobs failed on following builders:
  Catapult Linux Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Li...)

[nednguyen, 2016-12-10 13:11:29]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2016-12-10 13:11:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 14:12:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 14:12:36]

Try jobs failed on following builders:
  Catapult Linux Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Li...)

[Dirk Pranke, 2016-12-11 03:23:01]

lgtm

https://codereview.chromium.org/2562913003/diff/40001/telemetry/examples/brow...
File telemetry/examples/browser_tests/failed_tests.py (right):

https://codereview.chromium.org/2562913003/diff/40001/telemetry/examples/brow...
telemetry/examples/browser_tests/failed_tests.py:45: del loader, tests, pattern 
# Unused.
Nit: maybe use a pylint annotation here instead?

[nednguyen, 2016-12-11 13:01:44]

https://codereview.chromium.org/2562913003/diff/40001/telemetry/examples/brow...
File telemetry/examples/browser_tests/failed_tests.py (right):

https://codereview.chromium.org/2562913003/diff/40001/telemetry/examples/brow...
telemetry/examples/browser_tests/failed_tests.py:45: del loader, tests, pattern 
# Unused.
On 2016/12/11 03:23:01, Dirk Pranke wrote:
> Nit: maybe use a pylint annotation here instead?

This is our preferred pattern: go/del-for-unused (Googler only, sorry)

[nednguyen, 2016-12-12 18:44:38]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2016-12-12 18:44:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 19:11:27]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481568278764390,
"parent_rev": "b0ae6e2c7233785955653b09033c9cb48ee983b9", "commit_rev":
"670692248ead326cac18ed0eb4931cf3f27a5961"}

[commit-bot: I haz the power, 2016-12-12 19:11:29]

Description was changed from

==========
Move browser_test_runner.LoadAllTestsInModule to
serially_executed_browser_test_case

This also adds call to LoadAllTestsInModule for the load_tests method to the 
examples in telemetry/examples/.

Motivation: to migrate the core test_runner in  browser_test_runner, we need to 
make sure that typ can execute the code that generate the test case in the 
subprocesses.

BUG=chromium:636153
==========

to

==========
Move browser_test_runner.LoadAllTestsInModule to
serially_executed_browser_test_case

This also adds call to LoadAllTestsInModule for the load_tests method to the 
examples in telemetry/examples/.

Motivation: to migrate the core test_runner in  browser_test_runner, we need to 
make sure that typ can execute the code that generate the test case in the 
subprocesses.

BUG=chromium:636153

Review-Url: https://codereview.chromium.org/2562913003
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-12-12 19:11:30]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...