Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2616113002: Toggle High Contrast on Chrome OS should toggle on key down, not key up (Closed)

Created:
3 years, 11 months ago by oshima
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Toggle High Contrast on Chrome OS should toggle on key down, not key up This was just an accidental oversight. Triggering on key up means that if you're focused on a text box, the H key gets pressed. We deliberately picked Search+Shift as the modifier keys so that it wouldn't interfere with any web apps, so it's fine that it completely steals that key down event. BUG=676178, 644758 TBR=jamescook Review-Url: https://codereview.chromium.org/2592223002 Cr-Commit-Position: refs/heads/master@{#440255} (cherry picked from commit f7ea139838c04b7e254f70debe51e794beda2f1c) Review-Url: https://codereview.chromium.org/2616113002 . Cr-Commit-Position: refs/branch-heads/2924@{#687} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/0b13914173819e4465e4d6b7ef22562db399ee51

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ash/common/accelerators/accelerator_table.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
oshima
3 years, 11 months ago (2017-01-06 17:47:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0b13914173819e4465e4d6b7ef22562db399ee51.

Powered by Google App Engine
This is Rietveld 408576698