Chromium Code Reviews
DescriptionToggle High Contrast on Chrome OS should toggle on key down, not key up
This was just an accidental oversight. Triggering on key up means that
if you're focused on a text box, the H key gets pressed.
We deliberately picked Search+Shift as the modifier keys so that it wouldn't
interfere with any web apps, so it's fine that it completely steals that
key down event.
BUG=676178, 644758
TBR=jamescook
Review-Url: https://codereview.chromium.org/2592223002
Cr-Commit-Position: refs/heads/master@{#440255}
(cherry picked from commit f7ea139838c04b7e254f70debe51e794beda2f1c)
Review-Url: https://codereview.chromium.org/2616113002 .
Cr-Commit-Position: refs/branch-heads/2924@{#687}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Committed: https://chromium.googlesource.com/chromium/src/+/0b13914173819e4465e4d6b7ef22562db399ee51
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
|||||||||||||||||||