Toggle High Contrast on Chrome OS should toggle on key down, not key up

Toggle High Contrast on Chrome OS should toggle on key down, not key up

This was just an accidental oversight. Triggering on key up means that
if you're focused on a text box, the H key gets pressed.

We deliberately picked Search+Shift as the modifier keys so that it wouldn't
interfere with any web apps, so it's fine that it completely steals that
key down event.

BUG=676178, 644758
TBR=jamescook

Committed: https://crrev.com/f7ea139838c04b7e254f70debe51e794beda2f1c
Cr-Commit-Position: refs/heads/master@{#440255}

[dmazzoni, 2016-12-21 22:31:00]

dmazzoni@chromium.org changed reviewers:
+ jamescook@chromium.org

[dmazzoni, 2016-12-21 22:31:03]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2016-12-21 22:32:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 23:04:52]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482359463970200, "parent_rev":
"239f0b991c301a5153ca4668607b53ed837e5742", "commit_rev":
"554a23040f970dfa1ca24b1b7a2c2d1f34487f98"}

[commit-bot: I haz the power, 2016-12-21 23:05:19]

Description was changed from

==========
Toggle High Contrast on Chrome OS should toggle on key down, not key up

This was just an accidental oversight. Triggering on key up means that
if you're focused on a text box, the H key gets pressed.

We deliberately picked Search+Shift as the modifier keys so that it wouldn't
interfere with any web apps, so it's fine that it completely steals that
key down event.

BUG=676178,644758
TBR=jamescook
==========

to

==========
Toggle High Contrast on Chrome OS should toggle on key down, not key up

This was just an accidental oversight. Triggering on key up means that
if you're focused on a text box, the H key gets pressed.

We deliberately picked Search+Shift as the modifier keys so that it wouldn't
interfere with any web apps, so it's fine that it completely steals that
key down event.

BUG=676178,644758
TBR=jamescook

Review-Url: https://codereview.chromium.org/2592223002
==========

[commit-bot: I haz the power, 2016-12-21 23:05:21]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-21 23:08:04]

Description was changed from

==========
Toggle High Contrast on Chrome OS should toggle on key down, not key up

This was just an accidental oversight. Triggering on key up means that
if you're focused on a text box, the H key gets pressed.

We deliberately picked Search+Shift as the modifier keys so that it wouldn't
interfere with any web apps, so it's fine that it completely steals that
key down event.

BUG=676178,644758
TBR=jamescook

Review-Url: https://codereview.chromium.org/2592223002
==========

to

==========
Toggle High Contrast on Chrome OS should toggle on key down, not key up

This was just an accidental oversight. Triggering on key up means that
if you're focused on a text box, the H key gets pressed.

We deliberately picked Search+Shift as the modifier keys so that it wouldn't
interfere with any web apps, so it's fine that it completely steals that
key down event.

BUG=676178,644758
TBR=jamescook

Committed: https://crrev.com/f7ea139838c04b7e254f70debe51e794beda2f1c
Cr-Commit-Position: refs/heads/master@{#440255}
==========

[commit-bot: I haz the power, 2016-12-21 23:08:05]

Patchset 1 (id:??) landed as
https://crrev.com/f7ea139838c04b7e254f70debe51e794beda2f1c
Cr-Commit-Position: refs/heads/master@{#440255}

[James Cook, 2017-01-04 16:41:16]

lgtm