Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2616013002: Remove ContextClient from NavigatorCredentialManager (Closed)

Created:
3 years, 11 months ago by haraken
Modified:
3 years, 11 months ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ContextClient from NavigatorCredentialManager It's unused. BUG=610176 Review-Url: https://codereview.chromium.org/2616013002 Cr-Commit-Position: refs/heads/master@{#441892} Committed: https://chromium.googlesource.com/chromium/src/+/121a875ae1c674bccb03bd2453f5834bff6c28bd

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.h View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.cpp View 3 chunks +2 lines, -3 lines 2 comments Download

Messages

Total messages: 12 (8 generated)
haraken
PTAL https://codereview.chromium.org/2616013002/diff/1/third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.cpp File third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.cpp (left): https://codereview.chromium.org/2616013002/diff/1/third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.cpp#oldcode37 third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.cpp:37: if (!m_credentialsContainer && frame()) I don't think the ...
3 years, 11 months ago (2017-01-06 01:04:50 UTC) #3
sof
lgtm https://codereview.chromium.org/2616013002/diff/1/third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.cpp File third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.cpp (left): https://codereview.chromium.org/2616013002/diff/1/third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.cpp#oldcode37 third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.cpp:37: if (!m_credentialsContainer && frame()) On 2017/01/06 01:04:50, haraken ...
3 years, 11 months ago (2017-01-06 06:25:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616013002/1
3 years, 11 months ago (2017-01-06 06:27:08 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 06:33:05 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/121a875ae1c674bccb03bd2453f5...

Powered by Google App Engine
This is Rietveld 408576698