Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Unified Diff: third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.cpp

Issue 2616013002: Remove ContextClient from NavigatorCredentialManager (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.cpp
diff --git a/third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.cpp b/third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.cpp
index dbda6a66b3a025e7e8061b3ec9098d2855bebb55..53e68a28e3a79b74b03b304d2680a7727eef21df 100644
--- a/third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.cpp
+++ b/third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.cpp
@@ -13,7 +13,7 @@
namespace blink {
NavigatorCredentials::NavigatorCredentials(Navigator& navigator)
- : ContextClient(navigator.frame()) {}
+ : Supplement<Navigator>(navigator) {}
NavigatorCredentials& NavigatorCredentials::from(Navigator& navigator) {
NavigatorCredentials* supplement = static_cast<NavigatorCredentials*>(
@@ -34,7 +34,7 @@ CredentialsContainer* NavigatorCredentials::credentials(Navigator& navigator) {
}
CredentialsContainer* NavigatorCredentials::credentials() {
- if (!m_credentialsContainer && frame())
haraken 2017/01/06 01:04:50 I don't think the frame() check makes sense. So dr
sof 2017/01/06 06:25:57 yes, no implicit dependency on there being a frame
+ if (!m_credentialsContainer)
m_credentialsContainer = CredentialsContainer::create();
return m_credentialsContainer.get();
}
@@ -42,7 +42,6 @@ CredentialsContainer* NavigatorCredentials::credentials() {
DEFINE_TRACE(NavigatorCredentials) {
visitor->trace(m_credentialsContainer);
Supplement<Navigator>::trace(visitor);
- ContextClient::trace(visitor);
}
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698