Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 2616003002: Revert "[CUPS] Fix the browser crash in CUPS settings UI in guest mode." (Closed)

Created:
3 years, 11 months ago by skau
Modified:
3 years, 11 months ago
Reviewers:
stevenjb, xdai1
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, michaelpg+watch-md-settings_chromium.org, oshima+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "[CUPS] Fix the browser crash in CUPS settings UI in guest mode." This reverts commit 194dc32cac75a954d252d0a1b8ea4aa81eccd8ec. With https://codereview.chromium.org/2610373003/ enabling printing in incognito, we can reenable printer setup in Guest Mode. BUG=667395 Review-Url: https://codereview.chromium.org/2616003002 Cr-Commit-Position: refs/heads/master@{#441972} Committed: https://chromium.googlesource.com/chromium/src/+/20377bfe446fac2c6e8e6db8ff753b7995bf932b

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M chrome/browser/chromeos/printing/printer_pref_manager_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 3 chunks +3 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (12 generated)
skau
I've tested this CL and we can now use printers in Guest Mode.
3 years, 11 months ago (2017-01-06 00:07:16 UTC) #2
xdai1
On 2017/01/06 00:07:16, skau wrote: > I've tested this CL and we can now use ...
3 years, 11 months ago (2017-01-06 00:11:47 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 2610373003 Patch 1). Please resolve the dependency and ...
3 years, 11 months ago (2017-01-06 01:00:31 UTC) #6
skau
stevenjb@: Please review as ui/webui OWNER
3 years, 11 months ago (2017-01-06 06:19:56 UTC) #8
stevenjb
lgtm
3 years, 11 months ago (2017-01-06 16:53:48 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616003002/20001
3 years, 11 months ago (2017-01-06 17:44:03 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 17:53:05 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/20377bfe446fac2c6e8e6db8ff75...

Powered by Google App Engine
This is Rietveld 408576698