Let the incognito window print.

Let the incognito window print.

Provide the original profile to incognito so that users can still use
their printers.

BUG=678796
Review-Url: https://codereview.chromium.org/2610373003
Cr-Commit-Position: refs/heads/master@{#441812}
Committed: https://chromium.googlesource.com/chromium/src/+/27494ab927ec654ef673ea335e6406518d4216aa

[skau, 2017-01-05 23:05:45]

skau@chromium.org changed reviewers:
+ xdai@chromium.org

[skau, 2017-01-05 23:06:42]

The CQ bit was checked by skau@chromium.org

[skau, 2017-01-05 23:06:43]

The CQ bit was unchecked by skau@chromium.org

[xdai1, 2017-01-05 23:30:38]

lgtm 
Does it also work for guest user?

[skau, 2017-01-05 23:32:10]

On 2017/01/05 23:30:38, xdai1 wrote:
> lgtm 
> Does it also work for guest user?

Guest user isn't crashing if that's what you're asking.

[skau, 2017-01-05 23:32:17]

The CQ bit was checked by skau@chromium.org

[commit-bot: I haz the power, 2017-01-05 23:33:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xdai1, 2017-01-05 23:36:49]

On 2017/01/05 23:32:10, skau wrote:
> On 2017/01/05 23:30:38, xdai1 wrote:
> > lgtm 
> > Does it also work for guest user?
> 
> Guest user isn't crashing if that's what you're asking.

I suspect that with your CL in place, we can also use CUPS printing UI in guest
mode, see crbug.com/667395, which means we might not need this CL any more:
https://codereview.chromium.org/2535303003/. Could you please help to test it?

[skau, 2017-01-06 00:00:13]

Sure thing.  I'll revert the commit and try to run it.

On Thu, Jan 5, 2017 at 3:36 PM <xdai@chromium.org> wrote:

> On 2017/01/05 23:32:10, skau wrote:
> > On 2017/01/05 23:30:38, xdai1 wrote:
> > > lgtm
> > > Does it also work for guest user?
> >
> > Guest user isn't crashing if that's what you're asking.
>
> I suspect that with your CL in place, we can also use CUPS printing UI in
> guest
> mode, see crbug.com/667395, which means we might not need this CL any
> more:
> https://codereview.chromium.org/2535303003/. Could you please help to
> test it?
>
> https://codereview.chromium.org/2610373003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2017-01-06 01:57:06]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483659137630380, "parent_rev":
"33233d198c4f17bc6016bb2f9f59e64232c7f541", "commit_rev":
"27494ab927ec654ef673ea335e6406518d4216aa"}

[commit-bot: I haz the power, 2017-01-06 01:57:33]

Description was changed from

==========
Let the incognito window print.

Provide the original profile to incognito so that users can still use
their printers.

BUG=678796
==========

to

==========
Let the incognito window print.

Provide the original profile to incognito so that users can still use
their printers.

BUG=678796

Review-Url: https://codereview.chromium.org/2610373003
Cr-Commit-Position: refs/heads/master@{#441812}
Committed:
https://chromium.googlesource.com/chromium/src/+/27494ab927ec654ef673ea335e64...
==========

[commit-bot: I haz the power, 2017-01-06 01:57:34]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/27494ab927ec654ef673ea335e64...