Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2615953003: Rename IGNORE_EXCEPTION to IGNORE_EXCEPTION_FOR_TESTING (Closed)

Created:
3 years, 11 months ago by haraken
Modified:
3 years, 11 months ago
Reviewers:
slangley, Yuki
CC:
chromium-reviews, shans, jsbell+idb_chromium.org, nektar+watch_chromium.org, eae+blinkwatch, fs, eric.carlson_apple.com, dominicc+watchlist_chromium.org, apavlov+blink_chromium.org, dmazzoni+watch_chromium.org, Srirama, kouhei+svg_chromium.org, kinuko+watch, rwlbuis, caseq+blink_chromium.org, krit, aboxhall, aboxhall+watch_chromium.org, blink-reviews-html_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, je_julie, blink-reviews-bindings_chromium.org, gavinp+loader_chromium.org, devtools-reviews_chromium.org, blink-reviews, gyuyoung2, loading-reviews_chromium.org, pdr+svgwatchlist_chromium.org, Eric Willigers, nessy, rjwright, cmumford, sof, lushnikov+blink_chromium.org, feature-media-reviews_chromium.org, dmazzoni, yuzo+watch_chromium.org, darktears, haraken, Nate Chapin, vcarbune.chromium, tyoshino+watch_chromium.org, mlamouri+watch-blink_chromium.org, blink-reviews-animation_chromium.org, gasubic, pfeldman+blink_chromium.org, nektarios, f(malita), dtseng+watch_chromium.org, Stephen Chennney, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename IGNORE_EXCEPTION to IGNORE_EXCEPTION_FOR_TESTING ExceptionState should not be ignored in production code unless you have a strong reason to do so. However, people have abused IGNORE_EXCEPTION and ignored ExceptionState that should not be ignored... To discourage further mis-usage, this CL renames IGNORE_EXCEPTION to IGNORE_EXCEPTION_FOR_TESTING. BUG=670619 Review-Url: https://codereview.chromium.org/2615953003 Cr-Commit-Position: refs/heads/master@{#441945} Committed: https://chromium.googlesource.com/chromium/src/+/44f9d281fad4e41cbb47dd63327754d41fd20190

Patch Set 1 #

Total comments: 2

Patch Set 2 : temp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -110 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ExceptionState.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ContainerNode.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Range.cpp View 1 chunk +9 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Text.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EphemeralRangeTest.cpp View 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/AppendNodeCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/DeleteFromTextNodeCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertIntoTextNodeCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertNodeBeforeCommand.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/MergeIdenticalElementsCommand.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/RemoveCSSPropertyCommand.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/RemoveNodeCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/SplitElementCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/SplitTextNodeCommand.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/WrapContentsInDummySpanCommand.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTableElement.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTitleElement.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/TimeRanges.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/TimeRangesTest.cpp View 2 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/InputType.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/RangeInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControls.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/DOMEditor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/DOMPatchSupport.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorHistory.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp View 1 chunk +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/loader/HttpEquiv.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTitleElement.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCDataChannelTest.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/storage/DOMWindowStorageController.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/LinkHighlightImplTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebNode.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
haraken
PTAL
3 years, 11 months ago (2017-01-06 13:01:46 UTC) #2
Yuki
LGTM. https://codereview.chromium.org/2615953003/diff/1/third_party/WebKit/Source/bindings/core/v8/ExceptionState.h File third_party/WebKit/Source/bindings/core/v8/ExceptionState.h (right): https://codereview.chromium.org/2615953003/diff/1/third_party/WebKit/Source/bindings/core/v8/ExceptionState.h#newcode217 third_party/WebKit/Source/bindings/core/v8/ExceptionState.h:217: // IGNORE_EXCEPTION_FOR_TESTING) nit: indent 4 spaces?
3 years, 11 months ago (2017-01-06 13:05:27 UTC) #3
haraken
https://codereview.chromium.org/2615953003/diff/1/third_party/WebKit/Source/bindings/core/v8/ExceptionState.h File third_party/WebKit/Source/bindings/core/v8/ExceptionState.h (right): https://codereview.chromium.org/2615953003/diff/1/third_party/WebKit/Source/bindings/core/v8/ExceptionState.h#newcode217 third_party/WebKit/Source/bindings/core/v8/ExceptionState.h:217: // IGNORE_EXCEPTION_FOR_TESTING) On 2017/01/06 13:05:27, Yuki wrote: > nit: ...
3 years, 11 months ago (2017-01-06 13:09:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615953003/20001
3 years, 11 months ago (2017-01-06 13:09:31 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/343527)
3 years, 11 months ago (2017-01-06 15:12:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615953003/20001
3 years, 11 months ago (2017-01-06 15:15:59 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 16:05:00 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/44f9d281fad4e41cbb47dd633277...

Powered by Google App Engine
This is Rietveld 408576698