Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

Issue 2615953003: Rename IGNORE_EXCEPTION to IGNORE_EXCEPTION_FOR_TESTING (Closed)
Patch Set: temp Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
4 * (C) 1999 Antti Koivisto (koivisto@kde.org) 4 * (C) 1999 Antti Koivisto (koivisto@kde.org)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights 6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights
7 * reserved. 7 * reserved.
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2010 Google Inc. All rights reserved. 9 * Copyright (C) 2010 Google Inc. All rights reserved.
10 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. 10 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
(...skipping 211 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 beforeElement = options()->item(before.getAsLong()); 222 beforeElement = options()->item(before.getAsLong());
223 else 223 else
224 beforeElement = nullptr; 224 beforeElement = nullptr;
225 225
226 insertBefore(elementToInsert, beforeElement, exceptionState); 226 insertBefore(elementToInsert, beforeElement, exceptionState);
227 setNeedsValidityCheck(); 227 setNeedsValidityCheck();
228 } 228 }
229 229
230 void HTMLSelectElement::remove(int optionIndex) { 230 void HTMLSelectElement::remove(int optionIndex) {
231 if (HTMLOptionElement* option = item(optionIndex)) 231 if (HTMLOptionElement* option = item(optionIndex))
232 option->remove(IGNORE_EXCEPTION); 232 option->remove(IGNORE_EXCEPTION_FOR_TESTING);
233 } 233 }
234 234
235 String HTMLSelectElement::value() const { 235 String HTMLSelectElement::value() const {
236 if (HTMLOptionElement* option = selectedOption()) 236 if (HTMLOptionElement* option = selectedOption())
237 return option->value(); 237 return option->value();
238 return ""; 238 return "";
239 } 239 }
240 240
241 void HTMLSelectElement::setValue(const String& value, bool sendEvents) { 241 void HTMLSelectElement::setValue(const String& value, bool sendEvents) {
242 HTMLOptionElement* option = nullptr; 242 HTMLOptionElement* option = nullptr;
(...skipping 1802 matching lines...) Expand 10 before | Expand all | Expand 10 after
2045 m_popupUpdater = nullptr; 2045 m_popupUpdater = nullptr;
2046 } 2046 }
2047 2047
2048 void HTMLSelectElement::didMutateSubtree() { 2048 void HTMLSelectElement::didMutateSubtree() {
2049 DCHECK(popupIsVisible()); 2049 DCHECK(popupIsVisible());
2050 DCHECK(m_popup); 2050 DCHECK(m_popup);
2051 m_popup->updateFromElement(PopupMenu::ByDOMChange); 2051 m_popup->updateFromElement(PopupMenu::ByDOMChange);
2052 } 2052 }
2053 2053
2054 } // namespace blink 2054 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698