Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2615933002: DevTools: Don't show blank placeholder in TextPrompt (Closed)

Created:
3 years, 11 months ago by einbinder
Modified:
3 years, 11 months ago
Reviewers:
dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Don't show blank placeholder in TextPrompt Empty placeholder text could cause TextPrompt to lose its editing caret BUG=none Review-Url: https://codereview.chromium.org/2615933002 Cr-Commit-Position: refs/heads/master@{#442043} Committed: https://chromium.googlesource.com/chromium/src/+/8721588a8e3929086174f79e107a34dcf4b774f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/textPrompt.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
einbinder
ptal
3 years, 11 months ago (2017-01-05 21:03:51 UTC) #2
dgozman
lgtm
3 years, 11 months ago (2017-01-06 19:35:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615933002/1
3 years, 11 months ago (2017-01-06 20:47:36 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 20:53:52 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8721588a8e3929086174f79e107a...

Powered by Google App Engine
This is Rietveld 408576698