third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js - Issue 2615933002: DevTools: Don't show blank placeholder in TextPrompt

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js

Issue 2615933002: DevTools: Don't show blank placeholder in TextPrompt (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js b/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js

index 8113627b4912b4cd035a5989f2c3b949b54080c4..896824713aae1ac05ad5ee80d6e7ad8712cbecff 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js

@@ -200,7 +200,10 @@ UI.TextPrompt = class extends Common.Object {

* @param {string} placeholder

setPlaceholder(placeholder) {

- this._element.setAttribute('data-placeholder', placeholder);

+ if (placeholder)

+ this._element.setAttribute('data-placeholder', placeholder);

+ else

+ this._element.removeAttribute('data-placeholder');

}

_removeFromElement() {

« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/ui/textPrompt.css » ('j') | no next file with comments »