Implements CSSPropertyAPI for the webkit-text-emphasis-style property.

Implements CSSPropertyAPI for the webkit-text-emphasis-style property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyWebkitTextEmphasis from the switch statement in
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIWebkitTextEmphasis.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIWebkitTextEmphasis.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIWebkitTextEmphasis.cpp, which implements
  CSSPropertyAPI.h.

BUG=668012
Review-Url: https://codereview.chromium.org/2609933005
Cr-Commit-Position: refs/heads/master@{#443987}
Committed: https://chromium.googlesource.com/chromium/src/+/7cc977a4e6d8777b07306bae3a154d76e733d6b7

[aazzam, 2017-01-05 04:13:38]

aazzam@google.com changed reviewers:
+ bugsnash@chromium.org

[Bugs Nash, 2017-01-05 04:24:11]

https://codereview.chromium.org/2609933005/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTextEmphasisStyle.cpp
(right):

https://codereview.chromium.org/2609933005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTextEmphasisStyle.cpp:5:
#include "core/css/properties/CSSPropertyAPIWebkitTextEmphasisStyle.h"
this file seems to be missing?

[aazzam, 2017-01-05 04:25:17]

Description was changed from

==========
Implemented CSSPropertyAPI for webkit-text-emphasis-style property.

Added CSSPropertyAPIWebkitTextEmphasisStyle which implements
CSSPropertyAPI for the webkit-text-emphasis-style property. Moved
parsing logic from CSSPropertyParser to the .cpp file. Added flag to
CSSProperties.in so that the .h file will be generated.

BUG=668012
==========

to

==========
Implemented CSSPropertyAPI for webkit-text-emphasis-style property.

Added CSSPropertyAPIWebkitTextEmphasisStyle which implements
CSSPropertyAPI for the webkit-text-emphasis-style property. Parsing
logic is the same as before, just was moved from CSSPropertyParser
to the .cpp file. Added flag to CSSProperties.in so that the .h
file will be generated.

BUG=668012
==========

[aazzam, 2017-01-05 04:25:56]

PTAL @bugsnash :)

https://codereview.chromium.org/2609933005/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTextEmphasisStyle.cpp
(right):

https://codereview.chromium.org/2609933005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTextEmphasisStyle.cpp:5:
#include "core/css/properties/CSSPropertyAPIWebkitTextEmphasisStyle.h"
On 2017/01/05 at 04:24:11, Bugs Nash wrote:
> this file seems to be missing?

the .h files are generated! so I added a flag in CSSProperties.in to say it
should be generated:)

[Bugs Nash, 2017-01-05 04:44:41]

https://codereview.chromium.org/2609933005/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTextEmphasisStyle.cpp
(right):

https://codereview.chromium.org/2609933005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTextEmphasisStyle.cpp:5:
#include "core/css/properties/CSSPropertyAPIWebkitTextEmphasisStyle.h"
On 2017/01/05 at 04:25:56, aazzam wrote:
> On 2017/01/05 at 04:24:11, Bugs Nash wrote:
> > this file seems to be missing?
> 
> the .h files are generated! so I added a flag in CSSProperties.in to say it
should be generated:)

(y)

https://codereview.chromium.org/2609933005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTextEmphasisStyle.cpp:7:
#include "core/css/CSSStringValue.h"
what is this needed for?

https://codereview.chromium.org/2609933005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTextEmphasisStyle.cpp:15:
const CSSValue* CSSPropertyAPIWebkitTextEmphasisStyle::parseSingleValue(
where is this being called from?

[aazzam, 2017-01-05 05:12:44]

PTAL @bugsnash :)

https://codereview.chromium.org/2609933005/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTextEmphasisStyle.cpp
(right):

https://codereview.chromium.org/2609933005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTextEmphasisStyle.cpp:7:
#include "core/css/CSSStringValue.h"
On 2017/01/05 at 04:44:41, Bugs Nash wrote:
> what is this needed for?

consumeString (line 22) returns a CSSStringValue, which is defined in
CSSStringValue.h, so it doesnt compile if i don't include this :)

https://codereview.chromium.org/2609933005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTextEmphasisStyle.cpp:15:
const CSSValue* CSSPropertyAPIWebkitTextEmphasisStyle::parseSingleValue(
On 2017/01/05 at 04:44:41, Bugs Nash wrote:
> where is this being called from?

in CSSPropertyParser.cpp, on this line -
https://codesearch.chromium.org/chromium/src/third_party/WebKit/Source/core/c...

[Bugs Nash, 2017-01-05 22:13:00]

On 2017/01/05 at 05:12:44, aazzam wrote:
> PTAL @bugsnash :)
> 
>
https://codereview.chromium.org/2609933005/diff/1/third_party/WebKit/Source/c...
> File
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTextEmphasisStyle.cpp
(right):
> 
>
https://codereview.chromium.org/2609933005/diff/1/third_party/WebKit/Source/c...
>
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTextEmphasisStyle.cpp:7:
#include "core/css/CSSStringValue.h"
> On 2017/01/05 at 04:44:41, Bugs Nash wrote:
> > what is this needed for?
> 
> consumeString (line 22) returns a CSSStringValue, which is defined in
CSSStringValue.h, so it doesnt compile if i don't include this :)
> 
>
https://codereview.chromium.org/2609933005/diff/1/third_party/WebKit/Source/c...
>
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTextEmphasisStyle.cpp:15:
const CSSValue* CSSPropertyAPIWebkitTextEmphasisStyle::parseSingleValue(
> On 2017/01/05 at 04:44:41, Bugs Nash wrote:
> > where is this being called from?
> 
> in CSSPropertyParser.cpp, on this line -
https://codesearch.chromium.org/chromium/src/third_party/WebKit/Source/core/c...

lgtm, but I don't fully understand how the generation magic is working here

[Bugs Nash, 2017-01-05 22:57:59]

https://codereview.chromium.org/2609933005/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTextEmphasisStyle.cpp
(right):

https://codereview.chromium.org/2609933005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTextEmphasisStyle.cpp:9:
#include "core/css/parser/CSSParserTokenRange.h"
can be forward declared instead of included

[aazzam, 2017-01-06 03:13:11]

aazzam@google.com changed reviewers:
+ sashab@chromium.org

[aazzam, 2017-01-06 03:13:11]

sashab rs lgtm please :)

[sashab, 2017-01-06 05:30:27]

lgtm

https://codereview.chromium.org/2609933005/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTextEmphasisStyle.cpp
(right):

https://codereview.chromium.org/2609933005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTextEmphasisStyle.cpp:7:
#include "core/css/CSSStringValue.h"
Ohh I just saw your comment to bugsnash@, otherwise I would have said the same
thing. That is so super annoying haha. Ok leave this here, and ignore the
comment on your other patch about removing this

https://codereview.chromium.org/2609933005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTextEmphasisStyle.cpp:8:
#include "core/css/CSSValueList.h"
+CSSIdentifierValue

[aazzam, 2017-01-08 01:39:59]

Description was changed from

==========
Implemented CSSPropertyAPI for webkit-text-emphasis-style property.

Added CSSPropertyAPIWebkitTextEmphasisStyle which implements
CSSPropertyAPI for the webkit-text-emphasis-style property. Parsing
logic is the same as before, just was moved from CSSPropertyParser
to the .cpp file. Added flag to CSSProperties.in so that the .h
file will be generated.

BUG=668012
==========

to

==========
Implemented CSSPropertyAPI for the webkit-text-emphasis-style property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyWebkitTextEmphasis from the switch statement in
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIWebkitTextEmphasis.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIWebkitTextEmphasis.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIWebkitTextEmphasis.cpp, which implements
  CSSPropertyAPI.h.
==========

[aazzam, 2017-01-08 01:44:33]

Description was changed from

==========
Implemented CSSPropertyAPI for the webkit-text-emphasis-style property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyWebkitTextEmphasis from the switch statement in
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIWebkitTextEmphasis.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIWebkitTextEmphasis.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIWebkitTextEmphasis.cpp, which implements
  CSSPropertyAPI.h.
==========

to

==========
Implemented CSSPropertyAPI for the webkit-text-emphasis-style property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyWebkitTextEmphasis from the switch statement in
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIWebkitTextEmphasis.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIWebkitTextEmphasis.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIWebkitTextEmphasis.cpp, which implements
  CSSPropertyAPI.h.

BUG=668012
==========

[aazzam, 2017-01-08 01:58:22]

Description was changed from

==========
Implemented CSSPropertyAPI for the webkit-text-emphasis-style property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyWebkitTextEmphasis from the switch statement in
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIWebkitTextEmphasis.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIWebkitTextEmphasis.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIWebkitTextEmphasis.cpp, which implements
  CSSPropertyAPI.h.

BUG=668012
==========

to

==========
Implements CSSPropertyAPI for the webkit-text-emphasis-style property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyWebkitTextEmphasis from the switch statement in
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIWebkitTextEmphasis.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIWebkitTextEmphasis.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIWebkitTextEmphasis.cpp, which implements
  CSSPropertyAPI.h.

BUG=668012
==========

[aazzam, 2017-01-10 00:24:13]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 00:25:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 01:50:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 01:50:46]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[aazzam, 2017-01-11 02:32:00]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 02:33:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 02:40:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 02:40:55]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[aazzam, 2017-01-11 06:29:53]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 06:30:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 06:33:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 06:33:06]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[aazzam, 2017-01-11 07:02:07]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 07:02:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 07:05:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 07:05:36]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[aazzam, 2017-01-16 23:13:58]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 23:14:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 23:24:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 23:24:42]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[aazzam, 2017-01-16 23:47:35]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 23:47:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 03:12:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 03:12:43]

Dry run: This issue passed the CQ dry run.

[aazzam, 2017-01-17 04:13:24]

The CQ bit was checked by aazzam@google.com

[aazzam, 2017-01-17 04:13:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
bugsnash@chromium.org, sashab@chromium.org
Link to the patchset: https://codereview.chromium.org/2609933005/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-17 04:13:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 04:18:07]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1484626404159280,
"parent_rev": "6c3a6239605570130a9d3e1eba0f4278fd2ec14e", "commit_rev":
"7cc977a4e6d8777b07306bae3a154d76e733d6b7"}

[commit-bot: I haz the power, 2017-01-17 04:19:43]

Description was changed from

==========
Implements CSSPropertyAPI for the webkit-text-emphasis-style property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyWebkitTextEmphasis from the switch statement in
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIWebkitTextEmphasis.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIWebkitTextEmphasis.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIWebkitTextEmphasis.cpp, which implements
  CSSPropertyAPI.h.

BUG=668012
==========

to

==========
Implements CSSPropertyAPI for the webkit-text-emphasis-style property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyWebkitTextEmphasis from the switch statement in
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIWebkitTextEmphasis.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIWebkitTextEmphasis.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIWebkitTextEmphasis.cpp, which implements
  CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2609933005
Cr-Commit-Position: refs/heads/master@{#443987}
Committed:
https://chromium.googlesource.com/chromium/src/+/7cc977a4e6d8777b07306bae3a15...
==========

[commit-bot: I haz the power, 2017-01-17 04:19:44]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/7cc977a4e6d8777b07306bae3a15...