Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2615753003: DevTools: do not subscribe to global object events from the widgets that are not necessarily dispos… (Closed)

Created:
3 years, 11 months ago by pfeldman
Modified:
3 years, 11 months ago
Reviewers:
dgozman, alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: do not subscribe to global object events from the widgets that are not necessarily disposed. Review-Url: https://codereview.chromium.org/2615753003 Cr-Commit-Position: refs/heads/master@{#441767} Committed: https://chromium.googlesource.com/chromium/src/+/61a02a639712b27b4d36836b0be912e4b254947b

Patch Set 1 #

Patch Set 2 : same #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sources/OpenResourceDialog.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
pfeldman
3 years, 11 months ago (2017-01-05 02:55:40 UTC) #2
alph
lgtm
3 years, 11 months ago (2017-01-05 03:03:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615753003/1
3 years, 11 months ago (2017-01-05 18:51:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615753003/20001
3 years, 11 months ago (2017-01-05 20:10:40 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 21:56:47 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/61a02a639712b27b4d36836b0be9...

Powered by Google App Engine
This is Rietveld 408576698