third_party/WebKit/Source/devtools/front_end/sources/OpenResourceDialog.js - Issue 2615753003: DevTools: do not subscribe to global object events from the widgets that are not necessarily dispos…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/OpenResourceDialog.js

Issue 2615753003: DevTools: do not subscribe to global object events from the widgets that are not necessarily dispos… (Closed)

Patch Set: same Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/sources/OpenResourceDialog.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/OpenResourceDialog.js b/third_party/WebKit/Source/devtools/front_end/sources/OpenResourceDialog.js

index 12ea268d1042c2c11f8a8e23bfb008f19108e966..1a228a51e8244d8e82216eaa1da15688c72ee04f 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/OpenResourceDialog.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/OpenResourceDialog.js

@@ -27,7 +27,8 @@ Sources.OpenResourceDialog = class extends Sources.FilteredUISourceCodeListDeleg

static show(sourcesView, query, defaultScores, history) {

var dialog = new Sources.OpenResourceDialog(sourcesView, defaultScores, history);

- Sources.OpenResourceDialog._instanceForTest = dialog;

+ if (InspectorFrontendHost.isUnderTest())

+ Sources.OpenResourceDialog._instanceForTest = dialog;

var filteredItemSelectionDialog = new UI.FilteredListWidget(dialog);

filteredItemSelectionDialog.showAsDialog();

filteredItemSelectionDialog.setQuery(query);

« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js » ('j') | no next file with comments »