Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issue 2615753002: Remove time ticks metrics and MetricServiceClient::OnLogUploadComplete (Closed)

Created:
3 years, 11 months ago by Steven Holte
Modified:
3 years, 11 months ago
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, bgoldman+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, asvitkine+watch_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, scf+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove time ticks metrics and MetricServiceClient::OnLogUploadComplete BUG= Review-Url: https://codereview.chromium.org/2615753002 Cr-Commit-Position: refs/heads/master@{#443421} Committed: https://chromium.googlesource.com/chromium/src/+/b710b9ba8df2a9b9d89bd338c487ed1eaa0d4a20

Patch Set 1 #

Patch Set 2 : iOS #

Patch Set 3 : More clients #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -204 lines) Patch
M android_webview/browser/aw_metrics_service_client.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/browser/aw_metrics_service_client.cc View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M blimp/engine/app/blimp_metrics_service_client.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M blimp/engine/app/blimp_metrics_service_client.cc View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.cc View 1 2 3 4 2 chunks +0 lines, -8 lines 0 comments Download
D chrome/browser/metrics/time_ticks_experiment_unittest.cc View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/metrics/time_ticks_experiment_win.h View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/metrics/time_ticks_experiment_win.cc View 1 chunk +0 lines, -116 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/browser/metrics/cast_metrics_service_client.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/browser/metrics/cast_metrics_service_client.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M components/metrics/metrics_service.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M components/metrics/metrics_service_client.h View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M components/metrics/test_metrics_service_client.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M components/metrics/test_metrics_service_client.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M ios/chrome/browser/metrics/ios_chrome_metrics_service_client.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/metrics/ios_chrome_metrics_service_client.mm View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M ios/chrome/today_extension/today_metrics_logger.mm View 1 2 3 2 chunks +0 lines, -5 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 6 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 32 (15 generated)
Steven Holte
3 years, 11 months ago (2017-01-04 23:15:04 UTC) #2
Steven Holte
+olivierrobin for ios/chrome/browser/metrics/ +wez for blimp/engine/app +rkaplow for everything else
3 years, 11 months ago (2017-01-05 00:52:28 UTC) #4
Wez
blimp/ LGTM
3 years, 11 months ago (2017-01-05 01:57:27 UTC) #5
Olivier
ios lgtm
3 years, 11 months ago (2017-01-05 07:40:58 UTC) #6
rkaplow
lgtm cool thanks for cleanup
3 years, 11 months ago (2017-01-05 15:31:38 UTC) #7
Steven Holte
3 years, 11 months ago (2017-01-05 21:58:27 UTC) #9
Steven Holte
+boliu for android_webview +asvitkine for chromecast/browser/metrics
3 years, 11 months ago (2017-01-05 22:00:11 UTC) #11
boliu
On 2017/01/05 22:00:11, Steven Holte wrote: > +boliu for android_webview rs lgtm > +asvitkine for ...
3 years, 11 months ago (2017-01-05 22:17:11 UTC) #12
Alexei Svitkine (slow)
LGTM - sweet!
3 years, 11 months ago (2017-01-05 23:31:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615753002/60001
3 years, 11 months ago (2017-01-11 00:37:29 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/97521)
3 years, 11 months ago (2017-01-11 02:16:10 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615753002/60001
3 years, 11 months ago (2017-01-11 20:30:39 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/98522)
3 years, 11 months ago (2017-01-11 21:29:39 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615753002/60001
3 years, 11 months ago (2017-01-12 21:13:41 UTC) #24
commit-bot: I haz the power
Failed to apply patch for chrome/browser/metrics/chrome_metrics_service_client.cc: While running git apply --index -p1; error: patch failed: ...
3 years, 11 months ago (2017-01-12 22:27:49 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615753002/80001
3 years, 11 months ago (2017-01-12 22:33:34 UTC) #29
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 00:51:03 UTC) #32
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/b710b9ba8df2a9b9d89bd338c487...

Powered by Google App Engine
This is Rietveld 408576698