Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: blimp/engine/app/blimp_metrics_service_client.cc

Issue 2615753002: Remove time ticks metrics and MetricServiceClient::OnLogUploadComplete (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « blimp/engine/app/blimp_metrics_service_client.h ('k') | chrome/browser/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "blimp/engine/app/blimp_metrics_service_client.h" 5 #include "blimp/engine/app/blimp_metrics_service_client.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/i18n/rtl.h" 8 #include "base/i18n/rtl.h"
9 #include "base/lazy_instance.h" 9 #include "base/lazy_instance.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 // CHANNEL_UNKNOWN is filtered in metrics visualization tools since the value 114 // CHANNEL_UNKNOWN is filtered in metrics visualization tools since the value
115 // typically implies a non-official build. 115 // typically implies a non-official build.
116 // Using CHANNEL_CANARY as a work around until channel is set here. 116 // Using CHANNEL_CANARY as a work around until channel is set here.
117 return metrics::SystemProfileProto::CHANNEL_CANARY; 117 return metrics::SystemProfileProto::CHANNEL_CANARY;
118 } 118 }
119 119
120 std::string BlimpMetricsServiceClient::GetVersionString() { 120 std::string BlimpMetricsServiceClient::GetVersionString() {
121 return version_info::GetVersionNumber(); 121 return version_info::GetVersionNumber();
122 } 122 }
123 123
124 void BlimpMetricsServiceClient::OnLogUploadComplete() {}
125
126 void BlimpMetricsServiceClient::InitializeSystemProfileMetrics( 124 void BlimpMetricsServiceClient::InitializeSystemProfileMetrics(
127 const base::Closure& done_callback) { 125 const base::Closure& done_callback) {
128 // Blimp requires no additional work to InitializeSystemProfileMetrics 126 // Blimp requires no additional work to InitializeSystemProfileMetrics
129 // and should proceed to the next call in the chain. 127 // and should proceed to the next call in the chain.
130 done_callback.Run(); 128 done_callback.Run();
131 } 129 }
132 130
133 void BlimpMetricsServiceClient::CollectFinalMetricsForLog( 131 void BlimpMetricsServiceClient::CollectFinalMetricsForLog(
134 const base::Closure& done_callback) { 132 const base::Closure& done_callback) {
135 // Blimp requires no additional work to CollectFinalMetricsForLog 133 // Blimp requires no additional work to CollectFinalMetricsForLog
(...skipping 20 matching lines...) Expand all
156 BlimpMetricsServiceClient::GetMetricsReportingDefaultState() { 154 BlimpMetricsServiceClient::GetMetricsReportingDefaultState() {
157 return metrics::EnableMetricsDefault::OPT_IN; 155 return metrics::EnableMetricsDefault::OPT_IN;
158 } 156 }
159 157
160 bool BlimpMetricsServiceClient::IsConsentGiven() { 158 bool BlimpMetricsServiceClient::IsConsentGiven() {
161 return true; 159 return true;
162 } 160 }
163 161
164 } // namespace engine 162 } // namespace engine
165 } // namespace blimp 163 } // namespace blimp
OLDNEW
« no previous file with comments | « blimp/engine/app/blimp_metrics_service_client.h ('k') | chrome/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698