Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2615743003:
view-mus: Fix DisableViewDoesNotActivateWidget by adding Show(). (Closed)
|
Created:
3 years, 11 months ago by Elliot Glaysher Modified:
3 years, 11 months ago Reviewers:
sky CC:
chromium-reviews, tfarina Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionview-mus: Fix DisableViewDoesNotActivateWidget by adding Show().
NWA was allowing invisible widgets to be activated, which
doesn't work in mus.
BUG=678070
Review-Url: https://codereview.chromium.org/2615743003
Cr-Commit-Position: refs/heads/master@{#442705}
Committed: https://chromium.googlesource.com/chromium/src/+/4eff32a08d7a941ffb0eec7919b7de3361201551
Patch Set 1 #Patch Set 2 : Try 2; this can't be committed, but does it fix the test everywher? #Patch Set 3 : Try to fix the input method test? #Patch Set 4 : Test visibility. #Messages
Total messages: 25 (21 generated)
The CQ bit was checked by erg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by erg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by erg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by erg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== view-mus: Connect root window activation to the DesktopNativeWidgetAura. BUG=678070 ========== to ========== view-mus: Fix DisableViewDoesNotActivateWidget by adding Show(). NWA was allowing invisible widgets to be activated, which doesn't work in mus. BUG=678070 ==========
erg@chromium.org changed reviewers: + sky@chromium.org
Nice, LGTM
The CQ bit was checked by erg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484085702376730,
"parent_rev": "af210b9fb582034f0fe5fde6f675a10ddc40954a", "commit_rev":
"4eff32a08d7a941ffb0eec7919b7de3361201551"}
Message was sent while issue was closed.
Description was changed from ========== view-mus: Fix DisableViewDoesNotActivateWidget by adding Show(). NWA was allowing invisible widgets to be activated, which doesn't work in mus. BUG=678070 ========== to ========== view-mus: Fix DisableViewDoesNotActivateWidget by adding Show(). NWA was allowing invisible widgets to be activated, which doesn't work in mus. BUG=678070 Review-Url: https://codereview.chromium.org/2615743003 Cr-Commit-Position: refs/heads/master@{#442705} Committed: https://chromium.googlesource.com/chromium/src/+/4eff32a08d7a941ffb0eec7919b7... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/4eff32a08d7a941ffb0eec7919b7... |
