Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: ui/views/widget/widget_interactive_uitest.cc

Issue 2615743003: view-mus: Fix DisableViewDoesNotActivateWidget by adding Show(). (Closed)
Patch Set: Test visibility. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/widget_interactive_uitest.cc
diff --git a/ui/views/widget/widget_interactive_uitest.cc b/ui/views/widget/widget_interactive_uitest.cc
index 5221a57dfc1a3336ebe2d43179398e1ba4b8a240..4f8b370442a6fbfd446ce24aefb67623c015e83e 100644
--- a/ui/views/widget/widget_interactive_uitest.cc
+++ b/ui/views/widget/widget_interactive_uitest.cc
@@ -998,10 +998,6 @@ TEST_F(WidgetTestInteractive, TouchSelectionQuickMenuIsNotActivated) {
#endif // defined(USE_AURA)
TEST_F(WidgetTestInteractive, DisableViewDoesNotActivateWidget) {
- // TODO: see http://crbug.com/678070 for details.
- if (IsMus())
- return;
-
#if defined(OS_WIN)
views_delegate()->set_use_desktop_native_widgets(true);
#endif // !defined(OS_WIN)
@@ -1017,6 +1013,7 @@ TEST_F(WidgetTestInteractive, DisableViewDoesNotActivateWidget) {
view1->SetFocusBehavior(View::FocusBehavior::ALWAYS);
widget1.GetRootView()->AddChildView(view1);
+ widget1.Show();
ActivateSync(&widget1);
FocusManager* focus_manager1 = widget1.GetFocusManager();
@@ -1035,6 +1032,7 @@ TEST_F(WidgetTestInteractive, DisableViewDoesNotActivateWidget) {
view2->SetFocusBehavior(View::FocusBehavior::ALWAYS);
widget2.GetRootView()->AddChildView(view2);
+ widget2.Show();
ActivateSync(&widget2);
EXPECT_TRUE(widget2.IsActive());
EXPECT_FALSE(widget1.IsActive());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698