Revert postscript code removal.

Revert postscript code removal.

Revert CL http://crrev.com/2608663003 in preparation for adding
postscript generation to Pdfium.

Note postscript generation code will not be called until additional
patches land. These patches will also include modifications needed to
make this code functional (currently missing a few compression functions).

BUG=

Review-Url: https://codereview.chromium.org/2615703002
Committed: https://pdfium.googlesource.com/pdfium/+/8d94b6687f27e1238f352939434704f75b330c1d

[rbpotter, 2017-01-04 20:40:03]

Description was changed from

==========
Revert postscript code removal.

Revert CL http://crrev.com/2608663003 in preparation for adding
postscript generation to Pdfium.

Note postscript generation code will not be called until additional
patches land. These patches will also include modifications needed to
make this code functional (currently missing a few compression functions).

BUG=
==========

to

==========
Revert postscript code removal.

Revert CL http://crrev.com/2608663003 in preparation for adding
postscript generation to Pdfium.

Note postscript generation code will not be called until additional
patches land. These patches will also include modifications needed to
make this code functional (currently missing a few compression functions).

BUG=
==========

[rbpotter, 2017-01-04 20:40:03]

rbpotter@chromium.org changed reviewers:
+ dsinclair@chromium.org, tsepez@chromium.org

[rbpotter, 2017-01-04 20:48:52]

This is a revert of the postscript generation code removal
in http://crrev.com/2019603002, with modifications so that
everything works with all the changes that have occurred in
the ~6 months since it was removed. This code was missing a
few key pieces to actually generate postscript, so this
does not actually add PS generation as it stands. The added
code is currently not called by anything. The missing
components and some changes to allow the code to be called
from chromium will need to be added in future patches.

[Tom Sepez, 2017-01-04 21:03:30]

OWNERS LGTM, though I didn't confirm all the "green" sections re-added.

[rbpotter, 2017-01-05 00:28:29]

The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 00:28:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 01:43:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 01:43:13]

Dry run: Try jobs failed on following builders:
  win_xfa_clang_32 on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_xfa_clang_3...)

[rbpotter, 2017-01-05 02:39:37]

Patchset #2 (id:20001) has been deleted

[rbpotter, 2017-01-05 02:39:44]

The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 02:39:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 02:48:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 02:48:47]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2017-01-05 17:13:44]

Added a few cleanup nits before we land.

https://codereview.chromium.org/2615703002/diff/40001/core/fxcodec/codec/fx_c...
File core/fxcodec/codec/fx_codec_fax.cpp (right):

https://codereview.chromium.org/2615703002/diff/40001/core/fxcodec/codec/fx_c...
core/fxcodec/codec/fx_codec_fax.cpp:48: int FindBit(const uint8_t* data_buf, int
max_pos, int start_pos, int bit) {
This one's a bit weird. Why do we change from a vector to a raw pointer?

https://codereview.chromium.org/2615703002/diff/40001/core/fxcodec/codec/fx_c...
File core/fxcodec/codec/fx_codec_jpeg.cpp (right):

https://codereview.chromium.org/2615703002/diff/40001/core/fxcodec/codec/fx_c...
core/fxcodec/codec/fx_codec_jpeg.cpp:89: extern "C" {
Can drop this extern "C" and combine with the other one.

https://codereview.chromium.org/2615703002/diff/40001/core/fxge/cfx_windowsde...
File core/fxge/cfx_windowsdevice.h (right):

https://codereview.chromium.org/2615703002/diff/40001/core/fxge/cfx_windowsde...
core/fxge/cfx_windowsdevice.h:15: #include "core/fxge/cfx_renderdevice.h"
Is this needed here?

https://codereview.chromium.org/2615703002/diff/40001/core/fxge/win32/fx_ge_p...
File core/fxge/win32/fx_ge_ps.cpp (right):

https://codereview.chromium.org/2615703002/diff/40001/core/fxge/win32/fx_ge_p...
core/fxge/win32/fx_ge_ps.cpp:8: 
Rename this file as well.

https://codereview.chromium.org/2615703002/diff/40001/core/fxge/win32/fx_ge_ps.h
File core/fxge/win32/fx_ge_ps.h (right):

https://codereview.chromium.org/2615703002/diff/40001/core/fxge/win32/fx_ge_p...
core/fxge/win32/fx_ge_ps.h:23: class IFX_PSOutput {
Followup to see if this I class is really needed?

https://codereview.chromium.org/2615703002/diff/40001/core/fxge/win32/fx_ge_p...
core/fxge/win32/fx_ge_ps.h:32: class CFX_PSRenderer {
Can we rename this file to cfx_psrenderer.h so it will have the correct name?

https://codereview.chromium.org/2615703002/diff/40001/core/fxge/win32/win32_i...
File core/fxge/win32/win32_int.h (right):

https://codereview.chromium.org/2615703002/diff/40001/core/fxge/win32/win32_i...
core/fxge/win32/win32_int.h:266: class CPSOutput : public IFX_PSOutput {
Can this go in its own file? (Same with the cpp bits)

[rbpotter, 2017-01-05 22:47:37]

The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 22:47:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rbpotter, 2017-01-05 22:58:19]

Moved things around to clean up file names, removed
unnecessary class, and changed some of the restored
functions to take pointers vs pass by reference per git cl
lint suggestions.

https://codereview.chromium.org/2615703002/diff/40001/core/fxcodec/codec/fx_c...
File core/fxcodec/codec/fx_codec_fax.cpp (right):

https://codereview.chromium.org/2615703002/diff/40001/core/fxcodec/codec/fx_c...
core/fxcodec/codec/fx_codec_fax.cpp:48: int FindBit(const uint8_t* data_buf, int
max_pos, int start_pos, int bit) {
On 2017/01/05 17:13:43, dsinclair wrote:
> This one's a bit weird. Why do we change from a vector to a raw pointer?

The encoder needs to call this function on rows of the source data. The source
data is represented as a raw pointer in order to avoid copying it and to easily
step through the rows. Previously the only caller called it on the reference
buffer for the decoder, which is a vector whose data gets rewritten on each
iteration. The other option would be to create a vector to pass in here and copy
the source data rows to it each iteration. Let me know if you think this would
be better.

https://codereview.chromium.org/2615703002/diff/40001/core/fxcodec/codec/fx_c...
File core/fxcodec/codec/fx_codec_jpeg.cpp (right):

https://codereview.chromium.org/2615703002/diff/40001/core/fxcodec/codec/fx_c...
core/fxcodec/codec/fx_codec_jpeg.cpp:89: extern "C" {
On 2017/01/05 17:13:43, dsinclair wrote:
> Can drop this extern "C" and combine with the other one.

Done.

https://codereview.chromium.org/2615703002/diff/40001/core/fxge/cfx_windowsde...
File core/fxge/cfx_windowsdevice.h (right):

https://codereview.chromium.org/2615703002/diff/40001/core/fxge/cfx_windowsde...
core/fxge/cfx_windowsdevice.h:15: #include "core/fxge/cfx_renderdevice.h"
On 2017/01/05 17:13:43, dsinclair wrote:
> Is this needed here?

Yes, the compiler complains about an undefined base class (below, line 29) if it
is removed.

https://codereview.chromium.org/2615703002/diff/40001/core/fxge/win32/fx_ge_p...
File core/fxge/win32/fx_ge_ps.cpp (right):

https://codereview.chromium.org/2615703002/diff/40001/core/fxge/win32/fx_ge_p...
core/fxge/win32/fx_ge_ps.cpp:8: 
On 2017/01/05 17:13:43, dsinclair wrote:
> Rename this file as well.

Done.

https://codereview.chromium.org/2615703002/diff/40001/core/fxge/win32/fx_ge_p...
core/fxge/win32/fx_ge_ps.cpp:426: CFX_MaybeOwned<CFX_DIBSource>
pConverted((CFX_DIBSource*)pSource);
Had to change this to this type due to the modifications to FX_DIBSource that
changed the return type of CloneConvert into a unique_ptr. pConverted was
previously a CFX_DIBSource* that was set equal to pSource using a C cast. I am
looking at the other uses of CFX_MaybeOwned now to try to find a different way
to do this. Let me know if you have any suggestions.

https://codereview.chromium.org/2615703002/diff/40001/core/fxge/win32/fx_ge_ps.h
File core/fxge/win32/fx_ge_ps.h (right):

https://codereview.chromium.org/2615703002/diff/40001/core/fxge/win32/fx_ge_p...
core/fxge/win32/fx_ge_ps.h:23: class IFX_PSOutput {
On 2017/01/05 17:13:43, dsinclair wrote:
> Followup to see if this I class is really needed?

Removed it. Think it was originally separate in case multiple Postscript
implementations existed for different OSes (CPSOutput contains an HDC member),
but since this is moving to the win32 folder and will be used for win only,
probably makes sense to just get rid of it. Let me know if you think it should
be added back.

https://codereview.chromium.org/2615703002/diff/40001/core/fxge/win32/fx_ge_p...
core/fxge/win32/fx_ge_ps.h:32: class CFX_PSRenderer {
On 2017/01/05 17:13:43, dsinclair wrote:
> Can we rename this file to cfx_psrenderer.h so it will have the correct name?

Done.

https://codereview.chromium.org/2615703002/diff/40001/core/fxge/win32/win32_i...
File core/fxge/win32/win32_int.h (right):

https://codereview.chromium.org/2615703002/diff/40001/core/fxge/win32/win32_i...
core/fxge/win32/win32_int.h:266: class CPSOutput : public IFX_PSOutput {
On 2017/01/05 17:13:43, dsinclair wrote:
> Can this go in its own file? (Same with the cpp bits)

Done.

[commit-bot: I haz the power, 2017-01-05 22:58:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 22:58:37]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2017-01-06 02:44:27]

lgtm thanks a lot for the cleanups.

[rbpotter, 2017-01-06 16:09:56]

The CQ bit was checked by rbpotter@chromium.org

[rbpotter, 2017-01-06 16:09:56]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2615703002/#ps60001
(title: "Move files, remove extra class, remove non const refs")

[commit-bot: I haz the power, 2017-01-06 16:10:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 16:10:19]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483718996279800,
"parent_rev": "469f6da247ffe77d0ae6089e5d93db0b0c0bb37e", "commit_rev":
"8d94b6687f27e1238f352939434704f75b330c1d"}

[commit-bot: I haz the power, 2017-01-06 16:10:24]

Description was changed from

==========
Revert postscript code removal.

Revert CL http://crrev.com/2608663003 in preparation for adding
postscript generation to Pdfium.

Note postscript generation code will not be called until additional
patches land. These patches will also include modifications needed to
make this code functional (currently missing a few compression functions).

BUG=
==========

to

==========
Revert postscript code removal.

Revert CL http://crrev.com/2608663003 in preparation for adding
postscript generation to Pdfium.

Note postscript generation code will not be called until additional
patches land. These patches will also include modifications needed to
make this code functional (currently missing a few compression functions).

BUG=

Review-Url: https://codereview.chromium.org/2615703002
Committed:
https://pdfium.googlesource.com/pdfium/+/8d94b6687f27e1238f352939434704f75b33...
==========

[commit-bot: I haz the power, 2017-01-06 16:10:24]

Committed patchset #3 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/8d94b6687f27e1238f352939434704f75b33...

[Lei Zhang, 2017-02-24 22:03:41]

thestig@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2017-02-24 22:03:42]

FTR, the CL description should have referred to http://crrev.com/2019603002
where I previously deleted all the PS code.