[GeometryInterface] Implement DOMQuad and DOMQuadInit.

[GeometryInterface] Implement DOMQuad and DOMQuadInit.

Objects implementing the DOMQuad interface represents a quadrilateral.
first, constructor was added in this CL.
and i will add other functions in follow up CL.

spec list:
https://drafts.fxtf.org/geometry/#domquad
https://drafts.fxtf.org/geometry/#dictdef-domquadinit

BUG=678237
Review-Url: https://codereview.chromium.org/2615653003
Cr-Commit-Position: refs/heads/master@{#443446}
Committed: https://chromium.googlesource.com/chromium/src/+/4ebe01d1636b1ed0b258584b2485470646f7aec9

[Hwanseung Lee, 2017-01-05 13:25:01]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 13:25:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hwanseung Lee, 2017-01-05 13:30:36]

Description was changed from

==========
[GeometryInterface] Implement DOMQuad and DOMQuadInit.

DOMQuad.idl and DOMQuadInit.idl files were added.

spec list:
https://drafts.fxtf.org/geometry/#domquad
https://drafts.fxtf.org/geometry/#dictdef-domquadinit

BUG=678237
==========

to

==========
[GeometryInterface] Implement DOMQuad and DOMQuadInit.

DOMQuad.idl and DOMQuadInit.idl files were added.
first, constructor was added in this CL.
and i will add other functions in follow up CL.

spec list:
https://drafts.fxtf.org/geometry/#domquad
https://drafts.fxtf.org/geometry/#dictdef-domquadinit

BUG=678237
==========

[commit-bot: I haz the power, 2017-01-05 15:23:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 15:23:33]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Hwanseung Lee, 2017-01-06 11:06:38]

Description was changed from

==========
[GeometryInterface] Implement DOMQuad and DOMQuadInit.

DOMQuad.idl and DOMQuadInit.idl files were added.
first, constructor was added in this CL.
and i will add other functions in follow up CL.

spec list:
https://drafts.fxtf.org/geometry/#domquad
https://drafts.fxtf.org/geometry/#dictdef-domquadinit

BUG=678237
==========

to

==========
[GeometryInterface] Implement DOMQuad and DOMQuadInit.

Objects implementing the DOMQuad interface represents a quadrilateral.
first, constructor was added in this CL.
and i will add other functions in follow up CL.

spec list:
https://drafts.fxtf.org/geometry/#domquad
https://drafts.fxtf.org/geometry/#dictdef-domquadinit

BUG=678237
==========

[Hwanseung Lee, 2017-01-06 11:07:02]

The CQ bit was checked by hs1217.lee@samsung.com

[Hwanseung Lee, 2017-01-06 11:07:03]

The CQ bit was unchecked by hs1217.lee@samsung.com

[Hwanseung Lee, 2017-01-06 11:07:05]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 11:07:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 15:36:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 15:36:02]

Dry run: This issue passed the CQ dry run.

[Hwanseung Lee, 2017-01-07 09:03:23]

hs1217.lee@samsung.com changed reviewers:
+ dominicc@chromium.org, jinho.bang@samsung.com

[Hwanseung Lee, 2017-01-07 09:03:23]

@dominicc, zino
PTAL, thank you.

[zino, 2017-01-08 17:52:30]

https://codereview.chromium.org/2615653003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DOMQuad.h (right):

https://codereview.chromium.org/2615653003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DOMQuad.h:10: #include "core/dom/DOMPoint.h"
Can we use forward declaration instead of adding header?

https://codereview.chromium.org/2615653003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DOMQuad.idl (right):

https://codereview.chromium.org/2615653003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DOMQuad.idl:6: 
nit: unnecessary blank line?

https://codereview.chromium.org/2615653003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DOMQuad.idl:10: optional DOMPointInit p3,
optional DOMPointInit p4),
It's better to align with the line just above.

https://codereview.chromium.org/2615653003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DOMQuad.idl:11: // FIXME:
Exposed=(Window,Worker),
Why do you leave FIXME comment here?

https://codereview.chromium.org/2615653003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DOMQuad.idl:14: // FIXME: [NewObject] static
DOMQuad fromRect(optional DOMRectInit other);
According to coding style guide, we should use TODO(hs1217.lee) instead of
FIXME.

[Hwanseung Lee, 2017-01-09 13:28:25]

@zino
PTAL, i fixed them.

https://codereview.chromium.org/2615653003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DOMQuad.h (right):

https://codereview.chromium.org/2615653003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DOMQuad.h:10: #include "core/dom/DOMPoint.h"
On 2017/01/08 17:52:30, zino wrote:
> Can we use forward declaration instead of adding header?

Done.

https://codereview.chromium.org/2615653003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DOMQuad.idl (right):

https://codereview.chromium.org/2615653003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DOMQuad.idl:6: 
On 2017/01/08 17:52:30, zino wrote:
> nit: unnecessary blank line?

Done.

https://codereview.chromium.org/2615653003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DOMQuad.idl:10: optional DOMPointInit p3,
optional DOMPointInit p4),
On 2017/01/08 17:52:30, zino wrote:
> It's better to align with the line just above.

Done.

https://codereview.chromium.org/2615653003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DOMQuad.idl:11: // FIXME:
Exposed=(Window,Worker),
On 2017/01/08 17:52:30, zino wrote:
> Why do you leave FIXME comment here?

i will remove comment after implement all functions.
because when function added every time, we should add function name at every
expected file of tests.

https://codereview.chromium.org/2615653003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DOMQuad.idl:14: // FIXME: [NewObject] static
DOMQuad fromRect(optional DOMRectInit other);
On 2017/01/08 17:52:30, zino wrote:
> According to coding style guide, we should use TODO(hs1217.lee) instead of
> FIXME.

Done.

[zino, 2017-01-10 09:14:18]

LGTM

[dominicc (has gone to gerrit), 2017-01-11 08:07:54]

lgtm

lgtm modulo comment inline.

https://codereview.chromium.org/2615653003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/core_idl_files.gni (right):

https://codereview.chromium.org/2615653003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/core_idl_files.gni:513: "dom/DOMPointInit.idl",
Thank you for alphabetizing these.

https://codereview.chromium.org/2615653003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DOMQuad.h (right):

https://codereview.chromium.org/2615653003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DOMQuad.h:21: static DOMQuad*
create(DOMPointInit& p1,
Why not make these all const DOMPointInit&; same for the constructor.

https://codereview.chromium.org/2615653003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DOMQuad.idl (right):

https://codereview.chromium.org/2615653003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DOMQuad.idl:10: // FIXME:
Exposed=(Window,Worker)
Any reason not to just do this?

[Hwanseung Lee, 2017-01-11 13:34:04]

https://codereview.chromium.org/2615653003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DOMQuad.h (right):

https://codereview.chromium.org/2615653003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DOMQuad.h:21: static DOMQuad*
create(DOMPointInit& p1,
On 2017/01/11 08:07:54, dominicc wrote:
> Why not make these all const DOMPointInit&; same for the constructor.

Done.

https://codereview.chromium.org/2615653003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DOMQuad.idl (right):

https://codereview.chromium.org/2615653003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DOMQuad.idl:10: // FIXME:
Exposed=(Window,Worker)
On 2017/01/11 08:07:54, dominicc wrote:
> Any reason not to just do this?

no, i will fix it after all functions was completed.

[Hwanseung Lee, 2017-01-11 13:34:12]

The CQ bit was checked by hs1217.lee@samsung.com

[Hwanseung Lee, 2017-01-11 13:34:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
jinho.bang@samsung.com, dominicc@chromium.org
Link to the patchset: https://codereview.chromium.org/2615653003/#ps100001
(title: "add const keyword")

[commit-bot: I haz the power, 2017-01-11 13:34:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 15:16:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 15:16:24]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Hwanseung Lee, 2017-01-11 23:57:45]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 23:58:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 01:50:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 01:50:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Hwanseung Lee, 2017-01-12 21:24:03]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 21:24:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 01:20:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 01:20:45]

Dry run: This issue passed the CQ dry run.

[Hwanseung Lee, 2017-01-13 01:20:54]

The CQ bit was checked by hs1217.lee@samsung.com

[commit-bot: I haz the power, 2017-01-13 01:21:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 01:44:39]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1484270454517610,
"parent_rev": "59250b64593759462cdefbf4f411f1cca6e0c696", "commit_rev":
"4ebe01d1636b1ed0b258584b2485470646f7aec9"}

[commit-bot: I haz the power, 2017-01-13 01:45:10]

Description was changed from

==========
[GeometryInterface] Implement DOMQuad and DOMQuadInit.

Objects implementing the DOMQuad interface represents a quadrilateral.
first, constructor was added in this CL.
and i will add other functions in follow up CL.

spec list:
https://drafts.fxtf.org/geometry/#domquad
https://drafts.fxtf.org/geometry/#dictdef-domquadinit

BUG=678237
==========

to

==========
[GeometryInterface] Implement DOMQuad and DOMQuadInit.

Objects implementing the DOMQuad interface represents a quadrilateral.
first, constructor was added in this CL.
and i will add other functions in follow up CL.

spec list:
https://drafts.fxtf.org/geometry/#domquad
https://drafts.fxtf.org/geometry/#dictdef-domquadinit

BUG=678237

Review-Url: https://codereview.chromium.org/2615653003
Cr-Commit-Position: refs/heads/master@{#443446}
Committed:
https://chromium.googlesource.com/chromium/src/+/4ebe01d1636b1ed0b258584b2485...
==========

[commit-bot: I haz the power, 2017-01-13 01:45:11]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/4ebe01d1636b1ed0b258584b2485...