Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: third_party/WebKit/Source/core/dom/DOMQuad.idl

Issue 2615653003: [GeometryInterface] Implement DOMQuad and DOMQuadInit. (Closed)
Patch Set: [GeometryInterface] Implement DOMQuad and DOMQuadInit. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 // https://drafts.fxtf.org/geometry/#domquad
6
zino 2017/01/08 17:52:30 nit: unnecessary blank line?
Hwanseung Lee 2017/01/09 13:28:24 Done.
7
8 [
9 Constructor(optional DOMPointInit p1, optional DOMPointInit p2,
10 optional DOMPointInit p3, optional DOMPointInit p4),
zino 2017/01/08 17:52:30 It's better to align with the line just above.
Hwanseung Lee 2017/01/09 13:28:24 Done.
11 // FIXME: Exposed=(Window,Worker),
zino 2017/01/08 17:52:30 Why do you leave FIXME comment here?
Hwanseung Lee 2017/01/09 13:28:24 i will remove comment after implement all function
12 RuntimeEnabled=GeometryInterfaces,
13 ] interface DOMQuad {
14 // FIXME: [NewObject] static DOMQuad fromRect(optional DOMRectInit other);
zino 2017/01/08 17:52:30 According to coding style guide, we should use TOD
Hwanseung Lee 2017/01/09 13:28:24 Done.
15 // FIXME: [NewObject] static DOMQuad fromQuad(optional DOMQuadInit other);
16
17 [SameObject] readonly attribute DOMPoint p1;
18 [SameObject] readonly attribute DOMPoint p2;
19 [SameObject] readonly attribute DOMPoint p3;
20 [SameObject] readonly attribute DOMPoint p4;
21 // FIXME: [NewObject] DOMRect getBounds();
22
23 // FIXME: serializer = { attribute };
24 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698