Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2615613007: MD Settings: simplify layout of system page (Closed)

Created:
3 years, 11 months ago by Dan Beam
Modified:
3 years, 11 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: simplify layout of system page R=dschuyler@chromium.org BUG=673953 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2615613007 Cr-Commit-Position: refs/heads/master@{#442145} Committed: https://chromium.googlesource.com/chromium/src/+/9a9c64443887c1235b828b4797da27f3f633600f

Patch Set 1 #

Patch Set 2 : fix browser tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -41 lines) Patch
M chrome/browser/resources/settings/system_page/system_page.html View 1 3 chunks +19 lines, -41 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Dan Beam
3 years, 11 months ago (2017-01-06 02:32:43 UTC) #2
Dan Beam
ping
3 years, 11 months ago (2017-01-07 00:47:56 UTC) #11
dschuyler
lgtm
3 years, 11 months ago (2017-01-07 02:53:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615613007/20001
3 years, 11 months ago (2017-01-07 02:57:08 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-07 03:02:04 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9a9c64443887c1235b828b4797da...

Powered by Google App Engine
This is Rietveld 408576698