Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: chrome/browser/resources/settings/system_page/system_page.html

Issue 2615613007: MD Settings: simplify layout of system page (Closed)
Patch Set: fix browser tests Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-f lex-layout-classes.html">
2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> 3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">
3 <link rel="import" href="/controls/controlled_button.html"> 4 <link rel="import" href="/controls/controlled_button.html">
4 <link rel="import" href="/controls/extension_controlled_indicator.html"> 5 <link rel="import" href="/controls/extension_controlled_indicator.html">
5 <link rel="import" href="/controls/settings_checkbox.html"> 6 <link rel="import" href="/controls/settings_checkbox.html">
6 <link rel="import" href="/lifetime_browser_proxy.html"> 7 <link rel="import" href="/lifetime_browser_proxy.html">
7 <link rel="import" href="/prefs/prefs.html"> 8 <link rel="import" href="/prefs/prefs.html">
8 <link rel="import" href="/settings_shared_css.html"> 9 <link rel="import" href="/settings_shared_css.html">
9 <link rel="import" href="/system_page/system_page_browser_proxy.html"> 10 <link rel="import" href="/system_page/system_page_browser_proxy.html">
10 11
11 <dom-module id="settings-system-page"> 12 <dom-module id="settings-system-page">
12 <template> 13 <template>
13 <style include="settings-shared"> 14 <style include="settings-shared"></style>
14 /* TODO(dbeam): is it worth generalizing this style? Does something like
15 * this already exist (buttons after a checkbox in the same row)? */
16 #hardware-acceleration {
17 align-items: center;
18 display: flex;
19 }
20
21 #hardware-acceleration settings-checkbox {
22 flex: 1;
23 }
24
25 .proxy-wrapper {
26 align-items: center;
27 display: flex;
28 min-height: inherit;
29 }
30
31 extension-controlled-indicator {
32 width: 100%;
33 }
34 </style>
35 <div class="settings-box block first"> 15 <div class="settings-box block first">
36 <if expr="not is_macosx"> 16 <if expr="not is_macosx">
37 <settings-checkbox label="$i18n{backgroundAppsLabel}" 17 <settings-checkbox label="$i18n{backgroundAppsLabel}"
38 pref="{{prefs.background_mode.enabled}}"> 18 pref="{{prefs.background_mode.enabled}}">
39 </settings-checkbox> 19 </settings-checkbox>
40 </if> 20 </if>
41 <div id="hardware-acceleration"> 21 <div id="hardware-acceleration" class="layout horizontal center">
42 <settings-checkbox label="$i18n{hardwareAccelerationLabel}" 22 <settings-checkbox class="flex" label="$i18n{hardwareAccelerationLabel}"
43 pref="{{prefs.hardware_acceleration_mode.enabled}}"> 23 pref="{{prefs.hardware_acceleration_mode.enabled}}">
44 </settings-checkbox> 24 </settings-checkbox>
45 <template is="dom-if" if="[[shouldShowRestart_( 25 <template is="dom-if" if="[[shouldShowRestart_(
46 prefs.hardware_acceleration_mode.enabled.value)]]"> 26 prefs.hardware_acceleration_mode.enabled.value)]]">
47 <paper-button on-tap="onRestartTap_">$i18n{restart}</paper-button> 27 <paper-button on-tap="onRestartTap_">$i18n{restart}</paper-button>
48 </template> 28 </template>
49 </div> 29 </div>
50 </div> 30 </div>
51 <div class="settings-box block"> 31 <div class="settings-box">
52 <div class="proxy-wrapper"> 32 <controlled-button class="primary-button" pref="[[prefs.proxy]]"
53 <controlled-button class="primary-button" pref="[[prefs.proxy]]" 33 on-tap="onChangeProxySettingsTap_">
54 on-tap="onChangeProxySettingsTap_"> 34 $i18n{changeProxySettings}
55 $i18n{changeProxySettings} 35 </controlled-button>
56 </controlled-button> 36 </div>
37 <template is="dom-if" if="[[prefs.proxy.extensionId]]">
38 <div class="settings-box continuation">
39 <extension-controlled-indicator class="start"
40 extension-id="[[prefs.proxy.extensionId]]"
41 extension-name="[[prefs.proxy.controlledByName]]"
42 extension-can-be-disabled="[[prefs.proxy.extensionCanBeDisabled]]"
43 on-extension-disable="onExtensionDisable_">
44 </extension-controlled-indicator>
57 </div> 45 </div>
58 <template is="dom-if" if="[[prefs.proxy.extensionId]]"> 46 </template>
59 <div class="proxy-wrapper">
60 <extension-controlled-indicator
61 extension-id="[[prefs.proxy.extensionId]]"
62 extension-name="[[prefs.proxy.controlledByName]]"
63 extension-can-be-disabled="[[prefs.proxy.extensionCanBeDisabled]]"
64 on-extension-disable="onExtensionDisable_">
65 </extension-controlled-indicator>
66 </div>
67 </template>
68 </div>
69 </template> 47 </template>
70 <script src="/system_page/system_page.js"></script> 48 <script src="/system_page/system_page.js"></script>
71 </dom-module> 49 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698