Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2615613005: Fix missed legacy_page_test module update. (Closed)

Created:
3 years, 11 months ago by mattcary
Modified:
3 years, 11 months ago
Reviewers:
nednguyen, bustamante
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix missed legacy_page_test module update. This was missed by https://codereview.chromium.org/2539973004 BUG=678600 Review-Url: https://codereview.chromium.org/2615613005 Cr-Commit-Position: refs/heads/master@{#441786} Committed: https://chromium.googlesource.com/chromium/src/+/ddded05fefc02ea8728712c829adba8b48b39f3a

Patch Set 1 #

Patch Set 2 : bad upload, ignore #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M tools/chrome_proxy/common/chrome_proxy_metrics.py View 1 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mattcary
Hi! It appears Ned missed a legacy_page_test update, this is failing chrome-proxy-tests.
3 years, 11 months ago (2017-01-05 13:49:37 UTC) #2
nednguyen
lgtm
3 years, 11 months ago (2017-01-05 14:24:15 UTC) #3
bustamante
lgtm thanks!
3 years, 11 months ago (2017-01-05 23:53:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615613005/1
3 years, 11 months ago (2017-01-05 23:54:33 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 01:24:35 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ddded05fefc02ea8728712c829ad...

Powered by Google App Engine
This is Rietveld 408576698