Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2539973004: Update reference to page_test module to use legacy_page_test module (Closed)

Created:
4 years ago by nednguyen
Modified:
4 years ago
CC:
chromium-reviews, media-router+watch_chromium.org, jam, darin-cc_chromium.org, tbansal+watch-data-reduction-proxy_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update reference to page_test module to use legacy_page_test module BUG=606643 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/2b92d2891c2e7488162b59244ae1689be96f5374 Cr-Commit-Position: refs/heads/master@{#435798}

Patch Set 1 #

Patch Set 2 #

Patch Set 3 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -61 lines) Patch
M chrome/test/media_router/telemetry/benchmarks/media_router_measurements.py View 2 chunks +3 lines, -3 lines 0 comments Download
M content/test/gpu/gpu_tests/cloud_storage_test_base.py View 1 4 chunks +4 lines, -4 lines 0 comments Download
M content/test/gpu/gpu_tests/gpu_process.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/gpu/gpu_tests/gpu_rasterization.py View 1 2 chunks +6 lines, -5 lines 0 comments Download
M content/test/gpu/gpu_tests/gpu_test_base.py View 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/gpu/gpu_tests/hardware_accelerated_feature.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/gpu/gpu_tests/maps.py View 1 2 chunks +4 lines, -3 lines 0 comments Download
M content/test/gpu/gpu_tests/screenshot_sync.py View 1 3 chunks +4 lines, -3 lines 0 comments Download
M content/test/gpu/gpu_tests/trace_test.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/gpu/page_sets/gpu_process_tests.py View 1 10 chunks +27 lines, -20 lines 0 comments Download
M tools/chrome_proxy/common/chrome_proxy_measurements.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/chrome_proxy/common/chrome_proxy_metrics.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/chrome_proxy/common/network_metrics.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py View 6 chunks +6 lines, -6 lines 0 comments Download
M tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/chrome_proxy/live_tests/chrome_proxy_measurements.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/chrome_proxy/live_tests/chrome_proxy_metrics.py View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (12 generated)
nednguyen
+kbr for content/gpu/ +bustamante for tools/chrome_proxy/ + mfoltz for chrome/test/media_router/
4 years ago (2016-12-01 14:28:08 UTC) #3
nednguyen
On 2016/12/01 14:28:08, nednguyen wrote: > +kbr for content/gpu/ > +bustamante for tools/chrome_proxy/ > + ...
4 years ago (2016-12-01 22:15:03 UTC) #10
bustamante
lgtm for tools/chrome_proxy
4 years ago (2016-12-01 22:17:55 UTC) #11
Ken Russell (switch to Gerrit)
gpu_tests lgtm Sorry I haven't ported all of these to SeriallyExecutedBrowserTestCase yet.
4 years ago (2016-12-01 23:06:12 UTC) #12
nednguyen
+wez@ for chrome/test/media_router/
4 years ago (2016-12-01 23:12:34 UTC) #14
Wez
Is there a bug filed for migrating the MediaRouter test off of legacy_page_test?
4 years ago (2016-12-02 00:23:02 UTC) #15
nednguyen
On 2016/12/02 00:23:02, Wez wrote: > Is there a bug filed for migrating the MediaRouter ...
4 years ago (2016-12-02 00:27:20 UTC) #16
Wez
Thanks - LGTM :)
4 years ago (2016-12-02 00:42:46 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539973004/40001
4 years ago (2016-12-02 00:47:51 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-02 00:53:43 UTC) #21
commit-bot: I haz the power
4 years ago (2016-12-02 00:55:35 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2b92d2891c2e7488162b59244ae1689be96f5374
Cr-Commit-Position: refs/heads/master@{#435798}

Powered by Google App Engine
This is Rietveld 408576698