Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2615523002: Merge all test ICC profiles to one location (Closed)

Created:
3 years, 11 months ago by ccameron
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-test-runner_chromium.org, jam, darin-cc_chromium.org, blink-reviews, einbinder+watch-test-runner_chromium.org, kinuko+watch, jochen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge all test ICC profiles to one location This is a re-land of half of the code in https://codereview.chromium.org/2605743002 which was reverted because it changed layout test color. TBR=avi,esprehn BUG=634102 Committed: https://crrev.com/83e8e9a3c4597bac367eac402956b39fe6761b9b Cr-Commit-Position: refs/heads/master@{#441284}

Patch Set 1 #

Patch Set 2 : Fix ImageDecodeBench #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -1540 lines) Patch
M content/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/layouttest_support.cc View 2 chunks +5 lines, -543 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/ImageDecodeBench.cpp View 1 3 chunks +3 lines, -59 lines 0 comments Download
M ui/gfx/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M ui/gfx/color_space.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/color_space.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/gfx/color_transform_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D ui/gfx/icc_profile_unittest.h View 1 chunk +0 lines, -10 lines 0 comments Download
M ui/gfx/icc_profile_unittest.cc View 1 chunk +1 line, -308 lines 0 comments Download
A + ui/gfx/test/icc_profiles.h View 1 chunk +5 lines, -1 line 0 comments Download
A + ui/gfx/test/icc_profiles.cc View 5 chunks +27 lines, -612 lines 0 comments Download

Messages

Total messages: 16 (13 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615523002/20001
3 years, 11 months ago (2017-01-04 01:24:50 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-04 01:31:53 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 01:35:37 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/83e8e9a3c4597bac367eac402956b39fe6761b9b
Cr-Commit-Position: refs/heads/master@{#441284}

Powered by Google App Engine
This is Rietveld 408576698