Use consistent types for ICC profiles

Use consistent types for ICC profiles

In Blink we convert from a gfx::ICCProfile to a raw vector of data.
Stop doing this, and, instead, pass the gfx::ICCProfile (or its gfx::ColorSpace
or SkColorSpace, as appropriate).

Merge several locations where we store ICC profiles for testing
into ui/gfx/test/icc_profiles.

BUG=634102
TBR=esprehn

Committed: https://crrev.com/0b283e725b6489c7be426f1958419d19e8b348b7
Cr-Commit-Position: refs/heads/master@{#441004}

[ccameron, 2016-12-27 21:13:21]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-27 21:13:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2016-12-27 21:34:23]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-27 21:34:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2016-12-27 22:11:49]

Description was changed from

==========
Clean up ICC profile part 1

BUG=
==========

to

==========
Use consistent types for ICC profiles

In Blink we convert from a gfx::ICCProfile to a raw vector of data.
Stop doing this, and, instead, pass the gfx::ICCProfile (or its gfx::ColorSpace
or SkColorSpace, as appropriate).

Merge several locations where we store ICC profiles for testing
into ui/gfx/test/icc_profiles.

BUG=634102
==========

[ccameron, 2016-12-27 22:16:21]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-27 22:16:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2016-12-27 22:33:30]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-27 22:33:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-27 23:50:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-27 23:50:21]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[ccameron, 2016-12-28 00:07:32]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 00:07:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2016-12-28 00:56:00]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 00:56:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 02:25:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 02:25:40]

Dry run: This issue passed the CQ dry run.

[ccameron, 2016-12-28 14:28:07]

ccameron@chromium.org changed reviewers:
+ avi@chromium.org, chrishtr@chromium.org, esprehn@chromium.org

[ccameron, 2016-12-28 14:28:07]

Adding chrishtr for third_party/WebKit/public/web/

Adding esprehn for OWNER of remaining WebKit

Adding avi for OWNER of content/

[Avi (use Gerrit), 2016-12-28 16:09:41]

The code LGTM; it's kinda weird that you're using "color space" everywhere
rather than "color profile". If I had to name things I'd go with the latter but
it's not a disagreement I'd hold the CL over.

[jbroman, 2016-12-28 17:08:20]

https://codereview.chromium.org/2605743002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/ColorBehavior.cpp (right):

https://codereview.chromium.org/2605743002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/ColorBehavior.cpp:34: // Ensure that
the color space object be leaked.
nit: "is leaked"?

[ccameron, 2016-12-28 21:52:52]

On 2016/12/28 16:09:41, Avi wrote:
> The code LGTM; it's kinda weird that you're using "color space" everywhere
> rather than "color profile". If I had to name things I'd go with the latter
but
> it's not a disagreement I'd hold the CL over.

The "profile" is a pile of bits that are used to describe a color space, so, as
I'm moving newer and fewer things to use the pile-o-bits, I'm renaming them.

[ccameron, 2016-12-28 21:52:56]

https://codereview.chromium.org/2605743002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/ColorBehavior.cpp (right):

https://codereview.chromium.org/2605743002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/ColorBehavior.cpp:34: // Ensure that
the color space object be leaked.
On 2016/12/28 17:08:20, jbroman wrote:
> nit: "is leaked"?

It was intended to be the subjunctive ... but I'm not 100% sure that this is the
right place to use subjunctive.

[jbroman, 2016-12-29 00:09:29]

https://codereview.chromium.org/2605743002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/ColorBehavior.cpp (right):

https://codereview.chromium.org/2605743002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/ColorBehavior.cpp:34: // Ensure that
the color space object be leaked.
On 2016/12/28 at 21:52:56, ccameron wrote:
> On 2016/12/28 17:08:20, jbroman wrote:
> > nit: "is leaked"?
> 
> It was intended to be the subjunctive ... but I'm not 100% sure that this is
the right place to use subjunctive.

Indicative sounds better to me, but after searching the web it seems that there
are at least some people who think the subjunctive is fine here. So feel free to
disregard my comment. (I'd assumed a typo -- I don't mean to debate the finer
points of English grammar.)

[chrishtr, 2016-12-29 01:18:21]

lgtm

[chrishtr, 2016-12-29 01:18:24]

lgtm

[chrishtr, 2016-12-29 01:18:24]

lgtm

[ccameron, 2016-12-29 21:00:49]

Description was changed from

==========
Use consistent types for ICC profiles

In Blink we convert from a gfx::ICCProfile to a raw vector of data.
Stop doing this, and, instead, pass the gfx::ICCProfile (or its gfx::ColorSpace
or SkColorSpace, as appropriate).

Merge several locations where we store ICC profiles for testing
into ui/gfx/test/icc_profiles.

BUG=634102
==========

to

==========
Use consistent types for ICC profiles

In Blink we convert from a gfx::ICCProfile to a raw vector of data.
Stop doing this, and, instead, pass the gfx::ICCProfile (or its gfx::ColorSpace
or SkColorSpace, as appropriate).

Merge several locations where we store ICC profiles for testing
into ui/gfx/test/icc_profiles.

BUG=634102
TBR=esprehn
==========

[ccameron, 2016-12-29 21:00:55]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2016-12-29 21:01:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-29 23:45:01]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1483045255863130,
"parent_rev": "953b557607d6e53998c94ea7f20be9f876c8be97", "commit_rev":
"4b5e475c4a81ea639cdee75b592664657ceb7d2d"}

[commit-bot: I haz the power, 2016-12-29 23:45:31]

Description was changed from

==========
Use consistent types for ICC profiles

In Blink we convert from a gfx::ICCProfile to a raw vector of data.
Stop doing this, and, instead, pass the gfx::ICCProfile (or its gfx::ColorSpace
or SkColorSpace, as appropriate).

Merge several locations where we store ICC profiles for testing
into ui/gfx/test/icc_profiles.

BUG=634102
TBR=esprehn
==========

to

==========
Use consistent types for ICC profiles

In Blink we convert from a gfx::ICCProfile to a raw vector of data.
Stop doing this, and, instead, pass the gfx::ICCProfile (or its gfx::ColorSpace
or SkColorSpace, as appropriate).

Merge several locations where we store ICC profiles for testing
into ui/gfx/test/icc_profiles.

BUG=634102
TBR=esprehn

Review-Url: https://codereview.chromium.org/2605743002
==========

[commit-bot: I haz the power, 2016-12-29 23:45:33]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2017-01-02 15:53:46]

Description was changed from

==========
Use consistent types for ICC profiles

In Blink we convert from a gfx::ICCProfile to a raw vector of data.
Stop doing this, and, instead, pass the gfx::ICCProfile (or its gfx::ColorSpace
or SkColorSpace, as appropriate).

Merge several locations where we store ICC profiles for testing
into ui/gfx/test/icc_profiles.

BUG=634102
TBR=esprehn

Review-Url: https://codereview.chromium.org/2605743002
==========

to

==========
Use consistent types for ICC profiles

In Blink we convert from a gfx::ICCProfile to a raw vector of data.
Stop doing this, and, instead, pass the gfx::ICCProfile (or its gfx::ColorSpace
or SkColorSpace, as appropriate).

Merge several locations where we store ICC profiles for testing
into ui/gfx/test/icc_profiles.

BUG=634102
TBR=esprehn

Committed: https://crrev.com/0b283e725b6489c7be426f1958419d19e8b348b7
Cr-Commit-Position: refs/heads/master@{#441004}
==========

[commit-bot: I haz the power, 2017-01-02 15:53:47]

Patchset 5 (id:??) landed as
https://crrev.com/0b283e725b6489c7be426f1958419d19e8b348b7
Cr-Commit-Position: refs/heads/master@{#441004}

[engedy, 2017-01-02 16:59:57]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2609093002/ by engedy@chromium.org.

The reason for reverting is: Rebaselining not possible due to discrepancy
between test outputs produced by continuous builders vs. try jobs. See
crbug.com/677822 for details.

Speculatively reverting this CL as it has to do with ICC profiles and I am
mostly seeing differences of color shades in pixel diffs.

.