|
|
Chromium Code Reviews|
Created:
3 years, 11 months ago by emircan Modified:
3 years, 11 months ago Reviewers:
sandersd (OOO until July 31) CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd optional max supported resolution on MediaFoundationVideoEncodeAccelerator
This CL is a followup to https://codereview.chromium.org/2576073002.
Before reporting the max supported resolution for MFVEA, we test initializing a
session to make sure that it is not falsely reported. 1080p is the max resolution
reported by the documentation, and recently we found out that some systems can
support 2160p.
Earlier CL set 2160p as the max resolution to be tested, however based on drivers
and hardware some systems do not support it, see 677003. This CL modifies the
check such that 1080p is tested first and optional resolutions follow.
This increases the time GetSupportedProfiles() takes from ~40 ms to ~50 ms on
Lenovo P50.
BUG=590060, 677003
TEST=Tested AppRTC loopback with H264.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/363636b03eecfabd90f14f05ec3e1baf1d94d469
Cr-Commit-Position: refs/heads/master@{#441525}
Patch Set 1 #
Messages
Total messages: 24 (19 generated)
Description was changed from
==========
new res
{"pid":12596,"tid":17268,"ts":11459149201,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":50698,"tdur":49538,"tts":232758},
{"pid":19432,"tid":4416,"ts":11512042444,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":48300,"tdur":48936,"tts":228832},
{"pid":16976,"tid":17976,"ts":10706859475,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":17524,"tdur":16626,"tts":235244},
{"pid":17948,"tid":13720,"ts":10761804878,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":18426},
BUG=
==========
to
==========
new res
{"pid":12596,"tid":17268,"ts":11459149201,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":50698,"tdur":49538,"tts":232758},
{"pid":19432,"tid":4416,"ts":11512042444,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":48300,"tdur":48936,"tts":228832},
{"pid":16976,"tid":17976,"ts":10706859475,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":17524,"tdur":16626,"tts":235244},
{"pid":17948,"tid":13720,"ts":10761804878,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":18426},
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========
The CQ bit was checked by emircan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from
==========
new res
{"pid":12596,"tid":17268,"ts":11459149201,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":50698,"tdur":49538,"tts":232758},
{"pid":19432,"tid":4416,"ts":11512042444,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":48300,"tdur":48936,"tts":228832},
{"pid":16976,"tid":17976,"ts":10706859475,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":17524,"tdur":16626,"tts":235244},
{"pid":17948,"tid":13720,"ts":10761804878,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":18426},
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========
to
==========
Add optional max supported resolution on MediaFoundationVideoEncodeAccelerator
{"pid":12596,"tid":17268,"ts":11459149201,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":50698,"tdur":49538,"tts":232758},
{"pid":19432,"tid":4416,"ts":11512042444,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":48300,"tdur":48936,"tts":228832},
{"pid":16976,"tid":17976,"ts":10706859475,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":17524,"tdur":16626,"tts":235244},
{"pid":17948,"tid":13720,"ts":10761804878,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":18426},
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========
Description was changed from
==========
Add optional max supported resolution on MediaFoundationVideoEncodeAccelerator
{"pid":12596,"tid":17268,"ts":11459149201,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":50698,"tdur":49538,"tts":232758},
{"pid":19432,"tid":4416,"ts":11512042444,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":48300,"tdur":48936,"tts":228832},
{"pid":16976,"tid":17976,"ts":10706859475,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":17524,"tdur":16626,"tts":235244},
{"pid":17948,"tid":13720,"ts":10761804878,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":18426},
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========
to
==========
Add optional max supported resolution on MediaFoundationVideoEncodeAccelerator
{"pid":19180,"tid":14224,"ts":82441271975,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":38195,"tdur":36853,"tts":246934},
{"pid":9444,"tid":9452,"ts":82511462281,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":43826,"tdur":42672,"tts":224957},
{"pid":12748,"tid":15048,"ts":82581110435,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":42827,"tdur":41957,"tts":223594},
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========
Description was changed from
==========
Add optional max supported resolution on MediaFoundationVideoEncodeAccelerator
{"pid":19180,"tid":14224,"ts":82441271975,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":38195,"tdur":36853,"tts":246934},
{"pid":9444,"tid":9452,"ts":82511462281,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":43826,"tdur":42672,"tts":224957},
{"pid":12748,"tid":15048,"ts":82581110435,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":42827,"tdur":41957,"tts":223594},
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========
to
==========
Add optional max supported resolution on MediaFoundationVideoEncodeAccelerator
{"pid":19180,"tid":14224,"ts":82441271975,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":38195,"tdur":36853,"tts":246934},
{"pid":9444,"tid":9452,"ts":82511462281,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":43826,"tdur":42672,"tts":224957},
{"pid":12748,"tid":15048,"ts":82581110435,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":42827,"tdur":41957,"tts":223594},
{"pid":13728,"tid":9404,"ts":83956769813,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":51733,"tdur":50459,"tts":218708},
{"pid":12596,"tid":17268,"ts":11459149201,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":50698,"tdur":49538,"tts":232758},
{"pid":18284,"tid":10760,"ts":84056755957,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":52370,"tdur":50903,"tts":223904},
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========
The CQ bit was checked by emircan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from
==========
Add optional max supported resolution on MediaFoundationVideoEncodeAccelerator
{"pid":19180,"tid":14224,"ts":82441271975,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":38195,"tdur":36853,"tts":246934},
{"pid":9444,"tid":9452,"ts":82511462281,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":43826,"tdur":42672,"tts":224957},
{"pid":12748,"tid":15048,"ts":82581110435,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":42827,"tdur":41957,"tts":223594},
{"pid":13728,"tid":9404,"ts":83956769813,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":51733,"tdur":50459,"tts":218708},
{"pid":12596,"tid":17268,"ts":11459149201,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":50698,"tdur":49538,"tts":232758},
{"pid":18284,"tid":10760,"ts":84056755957,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":52370,"tdur":50903,"tts":223904},
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========
to
==========
Add optional max supported resolution on MediaFoundationVideoEncodeAccelerator
This CL is a followup to https://codereview.chromium.org/2576073002.
Before reporting the max supported resolution for MFVEA, we test initializing a
session to make sure that it is not falsely reported. 1080p is the max
resolution
reported by the documentation, and recently we found out that some systems can
support 2160p.
Earlier CL set 2160p as the max resolution to be tested, however based on
drivers
and hardware some systems do not support it. This CL modifies the check such
that
first 1080p is tested and optional resolutions are followed.
This increases the time GetSupportedProfiles() takes from ~40 ms to ~50 ms on
Lenovo P50.
BUG=590060
TEST=Tested AppRTC loopback with H264.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========
emircan@chromium.org changed reviewers: + sandersd@chromium.org
Patchset #1 (id:1) has been deleted
PTAL. This increases the time it takes to report max supported resolution from
~40 ms to ~50 ms on Lenovo P50 where 1080p and 2160p are supported. For systems
with no support it should not make any time difference.
BEFORE
{"pid":19180,"tid":14224,"ts":82441271975,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":38195,"tdur":36853,"tts":246934},
{"pid":9444,"tid":9452,"ts":82511462281,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":43826,"tdur":42672,"tts":224957},
{"pid":12748,"tid":15048,"ts":82581110435,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":42827,"tdur":41957,"tts":223594},
AFTER
{"pid":13728,"tid":9404,"ts":83956769813,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":51733,"tdur":50459,"tts":218708},
{"pid":12596,"tid":17268,"ts":11459149201,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":50698,"tdur":49538,"tts":232758},
{"pid":18284,"tid":10760,"ts":84056755957,"ph":"X","cat":"gpu,startup","name":"MediaFoundationVideoEncodeAccelerator::GetSupportedProfiles","args":{},"dur":52370,"tdur":50903,"tts":223904},
Description was changed from ========== Add optional max supported resolution on MediaFoundationVideoEncodeAccelerator This CL is a followup to https://codereview.chromium.org/2576073002. Before reporting the max supported resolution for MFVEA, we test initializing a session to make sure that it is not falsely reported. 1080p is the max resolution reported by the documentation, and recently we found out that some systems can support 2160p. Earlier CL set 2160p as the max resolution to be tested, however based on drivers and hardware some systems do not support it. This CL modifies the check such that first 1080p is tested and optional resolutions are followed. This increases the time GetSupportedProfiles() takes from ~40 ms to ~50 ms on Lenovo P50. BUG=590060 TEST=Tested AppRTC loopback with H264. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add optional max supported resolution on MediaFoundationVideoEncodeAccelerator This CL is a followup to https://codereview.chromium.org/2576073002. Before reporting the max supported resolution for MFVEA, we test initializing a session to make sure that it is not falsely reported. 1080p is the max resolution reported by the documentation, and recently we found out that some systems can support 2160p. Earlier CL set 2160p as the max resolution to be tested, however based on drivers and hardware some systems do not support it, see 677003. This CL modifies the check such that 1080p is tested first and optional resolutions follow. This increases the time GetSupportedProfiles() takes from ~40 ms to ~50 ms on Lenovo P50. BUG=590060,677003 TEST=Tested AppRTC loopback with H264. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
lgtm
The CQ bit was unchecked by emircan@chromium.org
The CQ bit was checked by emircan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483569430254720,
"parent_rev": "2ae3dbe34aec14b4b41d466a73715349a8a446af", "commit_rev":
"9d267dedec9b645bfc59de5982d2e8b38f5d0a8c"}
Message was sent while issue was closed.
Description was changed from ========== Add optional max supported resolution on MediaFoundationVideoEncodeAccelerator This CL is a followup to https://codereview.chromium.org/2576073002. Before reporting the max supported resolution for MFVEA, we test initializing a session to make sure that it is not falsely reported. 1080p is the max resolution reported by the documentation, and recently we found out that some systems can support 2160p. Earlier CL set 2160p as the max resolution to be tested, however based on drivers and hardware some systems do not support it, see 677003. This CL modifies the check such that 1080p is tested first and optional resolutions follow. This increases the time GetSupportedProfiles() takes from ~40 ms to ~50 ms on Lenovo P50. BUG=590060,677003 TEST=Tested AppRTC loopback with H264. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add optional max supported resolution on MediaFoundationVideoEncodeAccelerator This CL is a followup to https://codereview.chromium.org/2576073002. Before reporting the max supported resolution for MFVEA, we test initializing a session to make sure that it is not falsely reported. 1080p is the max resolution reported by the documentation, and recently we found out that some systems can support 2160p. Earlier CL set 2160p as the max resolution to be tested, however based on drivers and hardware some systems do not support it, see 677003. This CL modifies the check such that 1080p is tested first and optional resolutions follow. This increases the time GetSupportedProfiles() takes from ~40 ms to ~50 ms on Lenovo P50. BUG=590060,677003 TEST=Tested AppRTC loopback with H264. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2615513003 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add optional max supported resolution on MediaFoundationVideoEncodeAccelerator This CL is a followup to https://codereview.chromium.org/2576073002. Before reporting the max supported resolution for MFVEA, we test initializing a session to make sure that it is not falsely reported. 1080p is the max resolution reported by the documentation, and recently we found out that some systems can support 2160p. Earlier CL set 2160p as the max resolution to be tested, however based on drivers and hardware some systems do not support it, see 677003. This CL modifies the check such that 1080p is tested first and optional resolutions follow. This increases the time GetSupportedProfiles() takes from ~40 ms to ~50 ms on Lenovo P50. BUG=590060,677003 TEST=Tested AppRTC loopback with H264. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2615513003 ========== to ========== Add optional max supported resolution on MediaFoundationVideoEncodeAccelerator This CL is a followup to https://codereview.chromium.org/2576073002. Before reporting the max supported resolution for MFVEA, we test initializing a session to make sure that it is not falsely reported. 1080p is the max resolution reported by the documentation, and recently we found out that some systems can support 2160p. Earlier CL set 2160p as the max resolution to be tested, however based on drivers and hardware some systems do not support it, see 677003. This CL modifies the check such that 1080p is tested first and optional resolutions follow. This increases the time GetSupportedProfiles() takes from ~40 ms to ~50 ms on Lenovo P50. BUG=590060,677003 TEST=Tested AppRTC loopback with H264. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/363636b03eecfabd90f14f05ec3e1baf1d94d469 Cr-Commit-Position: refs/heads/master@{#441525} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/363636b03eecfabd90f14f05ec3e1baf1d94d469 Cr-Commit-Position: refs/heads/master@{#441525} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
