Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 2615513003: Add optional max supported resolution on MediaFoundationVideoEncodeAccelerator (Closed)

Created:
3 years, 11 months ago by emircan
Modified:
3 years, 11 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add optional max supported resolution on MediaFoundationVideoEncodeAccelerator This CL is a followup to https://codereview.chromium.org/2576073002. Before reporting the max supported resolution for MFVEA, we test initializing a session to make sure that it is not falsely reported. 1080p is the max resolution reported by the documentation, and recently we found out that some systems can support 2160p. Earlier CL set 2160p as the max resolution to be tested, however based on drivers and hardware some systems do not support it, see 677003. This CL modifies the check such that 1080p is tested first and optional resolutions follow. This increases the time GetSupportedProfiles() takes from ~40 ms to ~50 ms on Lenovo P50. BUG=590060, 677003 TEST=Tested AppRTC loopback with H264. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/363636b03eecfabd90f14f05ec3e1baf1d94d469 Cr-Commit-Position: refs/heads/master@{#441525}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -4 lines) Patch
M media/gpu/media_foundation_video_encode_accelerator_win.h View 1 chunk +4 lines, -0 lines 0 comments Download
M media/gpu/media_foundation_video_encode_accelerator_win.cc View 6 chunks +36 lines, -4 lines 0 comments Download

Messages

Total messages: 24 (19 generated)
emircan
PTAL. This increases the time it takes to report max supported resolution from ~40 ms ...
3 years, 11 months ago (2017-01-04 22:05:19 UTC) #14
sandersd (OOO until July 31)
lgtm
3 years, 11 months ago (2017-01-04 22:24:04 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615513003/20001
3 years, 11 months ago (2017-01-04 22:37:24 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:20001)
3 years, 11 months ago (2017-01-05 00:23:15 UTC) #22
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 00:25:36 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/363636b03eecfabd90f14f05ec3e1baf1d94d469
Cr-Commit-Position: refs/heads/master@{#441525}

Powered by Google App Engine
This is Rietveld 408576698