Adding compressed bytes to DRP pingback

Adding compressed bytes to DRP pingback

Compressed bytes represents the network bytes used for the page load.
This is accessible through page load metrics observer interface now.

BUG=678061
Review-Url: https://codereview.chromium.org/2615493002
Cr-Commit-Position: refs/heads/master@{#446169}
Committed: https://chromium.googlesource.com/chromium/src/+/c19a210cab019968afc9e2a93f6c738030574d49

[RyanSturm, 2017-01-03 21:25:37]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 21:25:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 22:17:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 22:17:48]

Dry run: This issue passed the CQ dry run.

[RyanSturm, 2017-01-18 23:55:52]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 23:56:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 00:21:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 00:21:30]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[RyanSturm, 2017-01-19 00:36:32]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 00:37:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[RyanSturm, 2017-01-19 00:37:52]

Patchset #3 (id:40001) has been deleted

[RyanSturm, 2017-01-19 00:38:01]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 00:38:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 01:49:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 01:49:38]

Dry run: This issue passed the CQ dry run.

[RyanSturm, 2017-01-19 20:36:11]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 20:36:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[RyanSturm, 2017-01-19 20:37:18]

Patchset #5 (id:100001) has been deleted

[commit-bot: I haz the power, 2017-01-19 20:38:06]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[RyanSturm, 2017-01-19 20:57:44]

ryansturm@chromium.org changed reviewers:
+ bmcquade@chromium.org, tbansal@chromium.org

[RyanSturm, 2017-01-19 20:57:44]

bmcquade: PTAL @ small D_R_P_MetricsObserver.cc change
tbansal: PTAL @ *

[RyanSturm, 2017-01-19 20:58:00]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 20:58:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[RyanSturm, 2017-01-19 21:35:46]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 21:36:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[RyanSturm, 2017-01-19 21:46:37]

ryansturm@chromium.org changed reviewers:
+ jpfeiff@chromium.org

[RyanSturm, 2017-01-19 21:46:38]

jpfeiff: proto change FYI

[tbansal1, 2017-01-19 22:01:18]

lgtm % comment

https://codereview.chromium.org/2615493002/diff/140001/components/data_reduct...
File components/data_reduction_proxy/proto/pageload_metrics.proto (right):

https://codereview.chromium.org/2615493002/diff/140001/components/data_reduct...
components/data_reduction_proxy/proto/pageload_metrics.proto:58: optional int32
original_page_size_kb = 10;
nitpicking: s/kb/kB/
https://en.wikipedia.org/wiki/Kilobyte says Kilobyte has symbol "kB"
https://en.wikipedia.org/wiki/Kilobit says kilobit has symbol "kb".

[RyanSturm, 2017-01-19 22:11:34]

https://codereview.chromium.org/2615493002/diff/140001/components/data_reduct...
File components/data_reduction_proxy/proto/pageload_metrics.proto (right):

https://codereview.chromium.org/2615493002/diff/140001/components/data_reduct...
components/data_reduction_proxy/proto/pageload_metrics.proto:58: optional int32
original_page_size_kb = 10;
On 2017/01/19 22:01:18, tbansal1 wrote:
> nitpicking: s/kb/kB/
> https://en.wikipedia.org/wiki/Kilobyte says Kilobyte has symbol "kB"
> https://en.wikipedia.org/wiki/Kilobit says kilobit has symbol "kb".

Acknowledged. Contextually, this should be understandable, and protos are lower
case.

[tbansal1, 2017-01-19 22:24:09]

https://codereview.chromium.org/2615493002/diff/140001/components/data_reduct...
File components/data_reduction_proxy/proto/pageload_metrics.proto (right):

https://codereview.chromium.org/2615493002/diff/140001/components/data_reduct...
components/data_reduction_proxy/proto/pageload_metrics.proto:58: optional int32
original_page_size_kb = 10;
On 2017/01/19 22:11:34, Ryan Sturm wrote:
> On 2017/01/19 22:01:18, tbansal1 wrote:
> > nitpicking: s/kb/kB/
> > https://en.wikipedia.org/wiki/Kilobyte says Kilobyte has symbol "kB"
> > https://en.wikipedia.org/wiki/Kilobit says kilobit has symbol "kb".
> 
> Acknowledged. Contextually, this should be understandable, and protos are
lower
> case.

OK, I will leave up to you. There have been cases in the past where this has
caused confusion in the past (http://shortn/_wNyN3swrgZ,
http://shortn/_1faZ2biMVU).

[commit-bot: I haz the power, 2017-01-19 22:54:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 22:54:12]

Dry run: This issue passed the CQ dry run.

[RyanSturm, 2017-01-25 22:12:29]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 22:13:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[RyanSturm, 2017-01-25 22:14:45]

-bmcquade (OOO) +csharrison
csharrison: PTAL @ p_l_m

jpfeiff: PTAL at pageload_metrics.proto

https://codereview.chromium.org/2615493002/diff/140001/components/data_reduct...
File components/data_reduction_proxy/proto/pageload_metrics.proto (right):

https://codereview.chromium.org/2615493002/diff/140001/components/data_reduct...
components/data_reduction_proxy/proto/pageload_metrics.proto:58: optional int32
original_page_size_kb = 10;
On 2017/01/19 22:24:09, tbansal1 wrote:
> On 2017/01/19 22:11:34, Ryan Sturm wrote:
> > On 2017/01/19 22:01:18, tbansal1 wrote:
> > > nitpicking: s/kb/kB/
> > > https://en.wikipedia.org/wiki/Kilobyte says Kilobyte has symbol "kB"
> > > https://en.wikipedia.org/wiki/Kilobit says kilobit has symbol "kb".
> > 
> > Acknowledged. Contextually, this should be understandable, and protos are
> lower
> > case.
> 
> OK, I will leave up to you. There have been cases in the past where this has
> caused confusion in the past (http://shortn/_wNyN3swrgZ,
> http://shortn/_1faZ2biMVU). 

obsolete

[RyanSturm, 2017-01-25 22:43:08]

ryansturm@chromium.org changed reviewers:
+ csharrison@chromium.org
- bmcquade@chromium.org, jpfeiff@chromium.org

[RyanSturm, 2017-01-25 22:43:08]

csharrison: PTAL @ p_l_m

[commit-bot: I haz the power, 2017-01-25 23:47:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 23:47:26]

Dry run: This issue passed the CQ dry run.

[Charlie Harrison, 2017-01-26 00:05:30]

lgtm

[RyanSturm, 2017-01-26 00:06:08]

The CQ bit was checked by ryansturm@chromium.org

[RyanSturm, 2017-01-26 00:06:09]

The patchset sent to the CQ was uploaded after l-g-t-m from tbansal@chromium.org
Link to the patchset: https://codereview.chromium.org/2615493002/#ps160001
(title: "changing proto to int64 instead of recuding to kb")

[commit-bot: I haz the power, 2017-01-26 00:07:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 00:16:28]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1485389168800530,
"parent_rev": "f70665f72a40d378c7bda5fc3aa6aec33dc93919", "commit_rev":
"c19a210cab019968afc9e2a93f6c738030574d49"}

[commit-bot: I haz the power, 2017-01-26 00:17:05]

Description was changed from

==========
Adding compressed bytes to DRP pingback

Compressed bytes represents the network bytes used for the page load.
This is accessible through page load metrics observer interface now.

BUG=678061
==========

to

==========
Adding compressed bytes to DRP pingback

Compressed bytes represents the network bytes used for the page load.
This is accessible through page load metrics observer interface now.

BUG=678061

Review-Url: https://codereview.chromium.org/2615493002
Cr-Commit-Position: refs/heads/master@{#446169}
Committed:
https://chromium.googlesource.com/chromium/src/+/c19a210cab019968afc9e2a93f6c...
==========

[commit-bot: I haz the power, 2017-01-26 00:17:06]

Committed patchset #7 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/c19a210cab019968afc9e2a93f6c...