Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: components/data_reduction_proxy/proto/pageload_metrics.proto

Issue 2615493002: Adding compressed bytes to DRP pingback (Closed)
Patch Set: moving to KB Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 syntax = "proto2"; 5 syntax = "proto2";
6 6
7 option optimize_for = LITE_RUNTIME; 7 option optimize_for = LITE_RUNTIME;
8 8
9 import "client_config.proto"; 9 import "client_config.proto";
10 10
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 optional Duration time_to_first_contentful_paint = 6; 48 optional Duration time_to_first_contentful_paint = 6;
49 // Time to first image paint. 49 // Time to first image paint.
50 optional Duration time_to_first_image_paint = 7; 50 optional Duration time_to_first_image_paint = 7;
51 // Time to first byte. 51 // Time to first byte.
52 optional Duration time_to_first_byte = 8; 52 optional Duration time_to_first_byte = 8;
53 // Time to onLoad event. 53 // Time to onLoad event.
54 optional Duration page_load_time = 9; 54 optional Duration page_load_time = 9;
55 55
56 // The sum of original-content-length values, over resources that were not 56 // The sum of original-content-length values, over resources that were not
57 // loaded from browser cache. 57 // loaded from browser cache.
58 optional int32 original_page_size_bytes = 10; 58 optional int32 original_page_size_kb = 10;
tbansal1 2017/01/19 22:01:18 nitpicking: s/kb/kB/ https://en.wikipedia.org/wiki
RyanSturm 2017/01/19 22:11:34 Acknowledged. Contextually, this should be underst
tbansal1 2017/01/19 22:24:09 OK, I will leave up to you. There have been cases
RyanSturm 2017/01/25 22:14:45 obsolete
59 // The sum of (compressed) content-length, over resources that were not loaded 59 // The sum of (compressed) content-length, over resources that were not loaded
60 // from browser cache. 60 // from browser cache.
61 optional int32 compressed_page_size_bytes = 11; 61 optional int32 compressed_page_size_kb = 11;
62 62
63 // The effective connection type at the start of the navigation. 63 // The effective connection type at the start of the navigation.
64 optional EffectiveConnectionType effective_connection_type = 12; 64 optional EffectiveConnectionType effective_connection_type = 12;
65 65
66 // The amount of time the parser was blocked by loading script. 66 // The amount of time the parser was blocked by loading script.
67 optional Duration parse_blocked_on_script_load_duration = 13; 67 optional Duration parse_blocked_on_script_load_duration = 13;
68 68
69 // Time until parsing finished. 69 // Time until parsing finished.
70 optional Duration parse_stop = 14; 70 optional Duration parse_stop = 14;
71 71
72 // Time to first meaningful paint. This measure is unstable and will change 72 // Time to first meaningful paint. This measure is unstable and will change
73 // over time. 73 // over time.
74 optional Duration experimental_time_to_first_meaningful_paint = 15; 74 optional Duration experimental_time_to_first_meaningful_paint = 15;
75 } 75 }
OLDNEW
« no previous file with comments | « components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698