Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2615463002: Use atomics when accessing m_didSetLooping (Closed)

Created:
3 years, 11 months ago by Raymond Toy
Modified:
3 years, 11 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews, haraken, Raymond Toy, hongchan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use atomics when accessing m_didSetLooping Add setter and getter methods for accessing m_didSetLooping so that we can access it atomically. The audio thread was reading this while the main thread could be writing it. Manually verified the test case from the bug that this fix works. (Need to reload the page a few times to trigger the original bug.) BUG=676874 TEST= Committed: https://crrev.com/310673a6eca24e30371c29593b4385fd3983ad1d Cr-Commit-Position: refs/heads/master@{#441304}

Patch Set 1 #

Patch Set 2 : Fix typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h View 1 3 chunks +8 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (12 generated)
Raymond Toy
PTAL
3 years, 11 months ago (2017-01-03 20:50:07 UTC) #3
hongchan
lgtm
3 years, 11 months ago (2017-01-03 21:22:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615463002/20001
3 years, 11 months ago (2017-01-03 23:45:48 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-04 02:56:54 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 03:00:18 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/310673a6eca24e30371c29593b4385fd3983ad1d
Cr-Commit-Position: refs/heads/master@{#441304}

Powered by Google App Engine
This is Rietveld 408576698