Chromium Code Reviews Chromium Code Reviews
Issue
2615293002:
Reland of [ios] Test new dialogs API in CRWWebControllerPageDialogOpenPolicyTest. (Closed)
DescriptionReland of [ios] Test new dialogs API in CRWWebControllerPageDialogOpenPolicyTest. (patchset #1 id:1 of https://codereview.chromium.org/2615283002/ )
Reason for revert:
Reverting broke tests on the main waterfall, so unreverting =)
Original issue's description:
> Revert of [ios] Test new dialogs API in CRWWebControllerPageDialogOpenPolicyTest. (patchset #1 id:1 of https://codereview.chromium.org/2613163002/ )
>
> Reason for revert:
> This is crashing on 32-bit devices.
>
> Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
> 0 com.apple.CoreFoundation 0x05b57301 _CFRelease + 1505
> 1 org.chromium.gtest.generic-unit-test 0x00a3afb7
> base::internal::ScopedNSProtocolTraitsRelease(objc_object*) + 39
> 2 org.chromium.gtest.generic-unit-test 0x00071d47
> base::internal::ScopedNSProtocolTraits<NSString*>::Release(NSString*) + 23
> 3 org.chromium.gtest.generic-unit-test 0x00071d28
> base::ScopedTypeRef<NSString*, base::internal::ScopedNSProtocolTraits<NSString*>
> >::~ScopedTypeRef() + 40
> 4 org.chromium.gtest.generic-unit-test 0x00071cf7
> base::scoped_nsprotocol<NSString*>::~scoped_nsprotocol() + 23
> 5 org.chromium.gtest.generic-unit-test 0x00071cd7
> base::scoped_nsobject<NSString>::~scoped_nsobject() + 23
> 6 org.chromium.gtest.generic-unit-test 0x00071567
> base::scoped_nsobject<NSString>::~scoped_nsobject() + 23
> 7 org.chromium.gtest.generic-unit-test 0x000716dd
> web::TestJavaScriptDialog::~TestJavaScriptDialog() + 45
> 8 org.chromium.gtest.generic-unit-test 0x00071707
> web::TestJavaScriptDialog::~TestJavaScriptDialog() + 23
> 9 org.chromium.gtest.generic-unit-test 0x00383724 (anonymous
> namespace)::CRWWebControllerPageDialogOpenPolicyTest_AllowConfirmWithTrue_Test::TestBody()
> + 4212
> 10 org.chromium.gtest.generic-unit-test 0x00adafe7 void
> testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test,
> void>(testing::Test*, void (testing::Test::*)(), char const*) + 103
> 11 org.chromium.gtest.generic-unit-test 0x00aae98a void
> testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,
> void>(testing::Test*, void (testing::Test::*)(), char const*) + 106
> 12 org.chromium.gtest.generic-unit-test 0x00aae8b6 testing::Test::Run() + 246
> 13 org.chromium.gtest.generic-unit-test 0x00ab062f testing::TestInfo::Run() +
> 255
> 14 org.chromium.gtest.generic-unit-test 0x00ab1d44 testing::TestCase::Run() +
> 260
> 15 org.chromium.gtest.generic-unit-test 0x00ac59ce
> testing::internal::UnitTestImpl::RunAllTests() + 974
> 16 org.chromium.gtest.generic-unit-test 0x00add3c7 bool
> testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,
> bool>(testing::internal::UnitTestImpl*, bool
> (testing::internal::UnitTestImpl::*)(), char const*) + 103
> 17 org.chromium.gtest.generic-unit-test 0x00ac559a bool
> testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,
> bool>(testing::internal::UnitTestImpl*, bool
> (testing::internal::UnitTestImpl::*)(), char const*) + 106
> 18 org.chromium.gtest.generic-unit-test 0x00ac549f testing::UnitTest::Run() +
> 335
> 19 org.chromium.gtest.generic-unit-test 0x00a4bc93 RUN_ALL_TESTS() + 19
>
> Original issue's description:
> > [ios] Test new dialogs API in CRWWebControllerPageDialogOpenPolicyTest.
> >
> > Use TestJavaScriptDialogPresenter instead of deprecated
> > CRWWebUserInterfaceDelegate.
> >
> > BUG=661445
> > TBR=kkhorimoto@chromium.org
> >
> > Review-Url: https://codereview.chromium.org/2613163002
> > Cr-Commit-Position: refs/heads/master@{#441998}
> > Committed: https://chromium.googlesource.com/chromium/src/+/e3cb6842bb7d440a8f8259bea661e5b97159fdca
>
> TBR=michaeldo@chromium.org,eugenebut@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=661445
>
> Review-Url: https://codereview.chromium.org/2615283002
> Cr-Commit-Position: refs/heads/master@{#442036}
> Committed: https://chromium.googlesource.com/chromium/src/+/8c9857238e62da4de34c8b02458418916c8a77d0
TBR=michaeldo@chromium.org,eugenebut@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=661445
Review-Url: https://codereview.chromium.org/2615293002
Cr-Commit-Position: refs/heads/master@{#442062}
Committed: https://chromium.googlesource.com/chromium/src/+/1cec8405fc3e76fb62641082f60787f4af6daad6
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|
|||||||||||||||||||
