Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1298)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2615283002: Revert of [ios] Test new dialogs API in CRWWebControllerPageDialogOpenPolicyTest. (Closed)

Created:
3 years, 11 months ago by rohitrao (ping after 24h)
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [ios] Test new dialogs API in CRWWebControllerPageDialogOpenPolicyTest. (patchset #1 id:1 of https://codereview.chromium.org/2613163002/ ) Reason for revert: This is crashing on 32-bit devices. Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.CoreFoundation 0x05b57301 _CFRelease + 1505 1 org.chromium.gtest.generic-unit-test 0x00a3afb7 base::internal::ScopedNSProtocolTraitsRelease(objc_object*) + 39 2 org.chromium.gtest.generic-unit-test 0x00071d47 base::internal::ScopedNSProtocolTraits<NSString*>::Release(NSString*) + 23 3 org.chromium.gtest.generic-unit-test 0x00071d28 base::ScopedTypeRef<NSString*, base::internal::ScopedNSProtocolTraits<NSString*> >::~ScopedTypeRef() + 40 4 org.chromium.gtest.generic-unit-test 0x00071cf7 base::scoped_nsprotocol<NSString*>::~scoped_nsprotocol() + 23 5 org.chromium.gtest.generic-unit-test 0x00071cd7 base::scoped_nsobject<NSString>::~scoped_nsobject() + 23 6 org.chromium.gtest.generic-unit-test 0x00071567 base::scoped_nsobject<NSString>::~scoped_nsobject() + 23 7 org.chromium.gtest.generic-unit-test 0x000716dd web::TestJavaScriptDialog::~TestJavaScriptDialog() + 45 8 org.chromium.gtest.generic-unit-test 0x00071707 web::TestJavaScriptDialog::~TestJavaScriptDialog() + 23 9 org.chromium.gtest.generic-unit-test 0x00383724 (anonymous namespace)::CRWWebControllerPageDialogOpenPolicyTest_AllowConfirmWithTrue_Test::TestBody() + 4212 10 org.chromium.gtest.generic-unit-test 0x00adafe7 void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) + 103 11 org.chromium.gtest.generic-unit-test 0x00aae98a void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) + 106 12 org.chromium.gtest.generic-unit-test 0x00aae8b6 testing::Test::Run() + 246 13 org.chromium.gtest.generic-unit-test 0x00ab062f testing::TestInfo::Run() + 255 14 org.chromium.gtest.generic-unit-test 0x00ab1d44 testing::TestCase::Run() + 260 15 org.chromium.gtest.generic-unit-test 0x00ac59ce testing::internal::UnitTestImpl::RunAllTests() + 974 16 org.chromium.gtest.generic-unit-test 0x00add3c7 bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) + 103 17 org.chromium.gtest.generic-unit-test 0x00ac559a bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) + 106 18 org.chromium.gtest.generic-unit-test 0x00ac549f testing::UnitTest::Run() + 335 19 org.chromium.gtest.generic-unit-test 0x00a4bc93 RUN_ALL_TESTS() + 19 Original issue's description: > [ios] Test new dialogs API in CRWWebControllerPageDialogOpenPolicyTest. > > Use TestJavaScriptDialogPresenter instead of deprecated > CRWWebUserInterfaceDelegate. > > BUG=661445 > TBR=kkhorimoto@chromium.org > > Review-Url: https://codereview.chromium.org/2613163002 > Cr-Commit-Position: refs/heads/master@{#441998} > Committed: https://chromium.googlesource.com/chromium/src/+/e3cb6842bb7d440a8f8259bea661e5b97159fdca TBR=michaeldo@chromium.org,eugenebut@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=661445 Review-Url: https://codereview.chromium.org/2615283002 Cr-Commit-Position: refs/heads/master@{#442036} Committed: https://chromium.googlesource.com/chromium/src/+/8c9857238e62da4de34c8b02458418916c8a77d0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -65 lines) Patch
M ios/web/web_state/ui/crw_web_controller_unittest.mm View 4 chunks +134 lines, -65 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
rohitrao (ping after 24h)
Created Revert of [ios] Test new dialogs API in CRWWebControllerPageDialogOpenPolicyTest.
3 years, 11 months ago (2017-01-06 20:40:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615283002/1
3 years, 11 months ago (2017-01-06 20:41:03 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/8c9857238e62da4de34c8b02458418916c8a77d0
3 years, 11 months ago (2017-01-06 20:42:11 UTC) #6
rohitrao (ping after 24h)
3 years, 11 months ago (2017-01-06 21:43:16 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2615293002/ by rohitrao@chromium.org.

The reason for reverting is: Reverting broke tests on the main waterfall, so
unreverting =).

Powered by Google App Engine
This is Rietveld 408576698