Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(994)

Unified Diff: content/browser/bluetooth/bluetooth_device_chooser_controller.cc

Issue 2615273002: Bump Bluetooth max filter name length from 29 bytes to 240 bytes (Closed)
Patch Set: Fix layout tests, begin to add new layout test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/bluetooth/bluetooth_device_chooser_controller.cc
diff --git a/content/browser/bluetooth/bluetooth_device_chooser_controller.cc b/content/browser/bluetooth/bluetooth_device_chooser_controller.cc
index 19cad9b7c8ea02382046bf52fcc3db903a22a406..569c3e7e5e7af970731bd3d166972559054abda5 100644
--- a/content/browser/bluetooth/bluetooth_device_chooser_controller.cc
+++ b/content/browser/bluetooth/bluetooth_device_chooser_controller.cc
@@ -79,8 +79,8 @@ namespace content {
bool BluetoothDeviceChooserController::use_test_scan_duration_ = false;
namespace {
-constexpr size_t kMaxLengthForDeviceName =
- 29; // max length of device name in filter.
+// Max length of device name in filter, limited to the max EIR packet size.
+constexpr size_t kMaxLengthForDeviceName = 240;
jeffcarp 2017/01/09 18:45:20 In my head it made more sense to limit it to 240 b
scheib 2017/01/09 19:26:49 I think this is OK too, practically I doubt device
// The duration of a Bluetooth Scan in seconds.
constexpr int kScanDuration = 60;

Powered by Google App Engine
This is Rietveld 408576698