Bump Bluetooth max filter name length from 29 bytes to 240 bytes

content/browser/bluetooth/bluetooth_device_chooser_controller.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/bluetooth/bluetooth_device_chooser_controller.h"
 
 #include <set>
 #include <string>
 #include <unordered_set>
 
@@ skipping 61 matching lines @@
 const int k60thPercentileRSSI = -55;
 const int k80thPercentileRSSI = -47;
 
 }  // namespace
 
 namespace content {
 
 bool BluetoothDeviceChooserController::use_test_scan_duration_ = false;
 
 namespace {
-constexpr size_t kMaxLengthForDeviceName =
-    29;  // max length of device name in filter.
+// Max length of device name in filter, limited to the max EIR packet size.
+constexpr size_t kMaxLengthForDeviceName = 240;

[jeffcarp, 2017/01/09 18:45:20]

In my head it made more sense to limit it to 240 bytes (not the 512 that was
discussed in the issue) since there's no way the name could be longer than 240.
Let me know if you prefer 512.

[scheib, 2017/01/09 19:26:49]

I think this is OK too, practically I doubt devices will be hitting this limit.
Please cite the spec sections and concepts that brought us to this number,
though.

 
 // The duration of a Bluetooth Scan in seconds.
 constexpr int kScanDuration = 60;
 constexpr int kTestScanDuration = 0;
 
 void LogRequestDeviceOptions(
     const blink::mojom::WebBluetoothRequestDeviceOptionsPtr& options) {
   VLOG(1) << "requestDevice called with the following filters: ";
   VLOG(1) << "acceptAllDevices: " << options->accept_all_devices;
 
@@ skipping 522 matching lines @@
 
 void BluetoothDeviceChooserController::PostErrorCallback(
     blink::mojom::WebBluetoothResult error) {
   if (!base::ThreadTaskRunnerHandle::Get()->PostTask(
           FROM_HERE, base::Bind(error_callback_, error))) {
     LOG(WARNING) << "No TaskRunner.";
   }
 }
 
 }  // namespace content