Bump Bluetooth max filter name length from 29 bytes to 240 bytes

third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp

Index: third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp
diff --git a/third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp b/third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp
index ac700a466c6ca5967edc954a55ef91ee1332ba24..e16f58dfde95fafa3cf2545b3e9b51a5587efb24 100644
--- a/third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp
+++ b/third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp
@@ -25,13 +25,13 @@
 namespace blink {
 
 namespace {
-// A device name can never be longer than 29 bytes. A adv packet is at most
-// 31 bytes long. The length and identifier of the length field take 2 bytes.
-// That least 29 bytes for the name.
-const size_t kMaxFilterNameLength = 29;
+// A name coming from an adv packet is max 29 bytes (adv packet max size
+// 31 bytes - 2 byte length field), but the name can also be acquired via
+// gap.device_name, so it is limited to the max EIR packet size of 240 bytes.
+const size_t kMaxFilterNameLength = 240;

[scheib, 2017/01/09 19:26:49]

Description here is good, please add spec sections that we used to look this up,
though.

 const char kFilterNameTooLong[] =
-    "A 'name' or 'namePrefix' longer than 29 bytes results in no devices being "
-    "found, because a device can't advertise a name longer than 29 bytes.";
+    "A 'name' or 'namePrefix' longer than 240 bytes results in no devices being "
+    "found, because a device can't acquire a name longer than 240 bytes.";
 // Per the Bluetooth Spec: The name is a user-friendly name associated with the
 // device and consists of a maximum of 248 bytes coded according to the UTF-8
 // standard.