Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2615163002: Remove ContextClient from DOMWindowQuota (Closed)

Created:
3 years, 11 months ago by haraken
Modified:
3 years, 11 months ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews, haraken, kinuko+fileapi, nhiroki, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ContextClient from DOMWindowQuota It's not needed. BUG=610176 Review-Url: https://codereview.chromium.org/2615163002 Cr-Commit-Position: refs/heads/master@{#441897} Committed: https://chromium.googlesource.com/chromium/src/+/ff41261e9ecf43ae2f61a10177cca9afe585607b

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M third_party/WebKit/Source/modules/quota/DOMWindowQuota.h View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/DOMWindowQuota.cpp View 3 chunks +2 lines, -3 lines 2 comments Download

Messages

Total messages: 12 (8 generated)
haraken
PTAL https://codereview.chromium.org/2615163002/diff/1/third_party/WebKit/Source/modules/quota/DOMWindowQuota.cpp File third_party/WebKit/Source/modules/quota/DOMWindowQuota.cpp (left): https://codereview.chromium.org/2615163002/diff/1/third_party/WebKit/Source/modules/quota/DOMWindowQuota.cpp#oldcode64 third_party/WebKit/Source/modules/quota/DOMWindowQuota.cpp:64: if (!m_storageInfo && frame()) I don't think the ...
3 years, 11 months ago (2017-01-06 01:37:22 UTC) #4
sof
lgtm https://codereview.chromium.org/2615163002/diff/1/third_party/WebKit/Source/modules/quota/DOMWindowQuota.cpp File third_party/WebKit/Source/modules/quota/DOMWindowQuota.cpp (left): https://codereview.chromium.org/2615163002/diff/1/third_party/WebKit/Source/modules/quota/DOMWindowQuota.cpp#oldcode64 third_party/WebKit/Source/modules/quota/DOMWindowQuota.cpp:64: if (!m_storageInfo && frame()) On 2017/01/06 01:37:22, haraken ...
3 years, 11 months ago (2017-01-06 07:25:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615163002/1
3 years, 11 months ago (2017-01-06 07:26:57 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 07:30:52 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ff41261e9ecf43ae2f61a10177cc...

Powered by Google App Engine
This is Rietveld 408576698