Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Unified Diff: third_party/WebKit/Source/modules/quota/DOMWindowQuota.cpp

Issue 2615163002: Remove ContextClient from DOMWindowQuota (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/quota/DOMWindowQuota.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/quota/DOMWindowQuota.cpp
diff --git a/third_party/WebKit/Source/modules/quota/DOMWindowQuota.cpp b/third_party/WebKit/Source/modules/quota/DOMWindowQuota.cpp
index edd1b46d6a559a246164081c5184adff6077c13c..7dd5f7a9458b78fe8cccd7637f34d6901c9e5804 100644
--- a/third_party/WebKit/Source/modules/quota/DOMWindowQuota.cpp
+++ b/third_party/WebKit/Source/modules/quota/DOMWindowQuota.cpp
@@ -38,7 +38,7 @@
namespace blink {
DOMWindowQuota::DOMWindowQuota(LocalDOMWindow& window)
- : ContextClient(window.frame()) {}
+ : Supplement<LocalDOMWindow>(window) {}
const char* DOMWindowQuota::supplementName() {
return "DOMWindowQuota";
@@ -61,7 +61,7 @@ DeprecatedStorageInfo* DOMWindowQuota::webkitStorageInfo(DOMWindow& window) {
}
DeprecatedStorageInfo* DOMWindowQuota::webkitStorageInfo() const {
- if (!m_storageInfo && frame())
haraken 2017/01/06 01:37:22 I don't think the frame check makes sense, so remo
sof 2017/01/06 07:25:49 Yes, same issue as https://codereview.chromium.org
+ if (!m_storageInfo)
m_storageInfo = DeprecatedStorageInfo::create();
return m_storageInfo.get();
}
@@ -69,7 +69,6 @@ DeprecatedStorageInfo* DOMWindowQuota::webkitStorageInfo() const {
DEFINE_TRACE(DOMWindowQuota) {
visitor->trace(m_storageInfo);
Supplement<LocalDOMWindow>::trace(visitor);
- ContextClient::trace(visitor);
}
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/modules/quota/DOMWindowQuota.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698