Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2615033002: [fullcodegen] Remove dead hole check logic (Closed)

Created:
3 years, 11 months ago by adamk
Modified:
3 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[fullcodegen] Remove dead hole check logic Variables requiring initialization are already forced into ignition, so all the code supporting hole checks in full-codegen and ast-graph-builder is dead. R=bmeurer@chromium.org BUG=v8:5657 Review-Url: https://codereview.chromium.org/2615033002 Cr-Commit-Position: refs/heads/master@{#42112} Committed: https://chromium.googlesource.com/v8/v8/+/45c11887929c1f0fbc54849d2627cd8bb90bcc37

Patch Set 1 #

Patch Set 2 : Remove all hole checks #

Patch Set 3 : More ports and AstGraphBuilder #

Patch Set 4 : x87 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -881 lines) Patch
M src/compiler/ast-graph-builder.h View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 2 8 chunks +14 lines, -150 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 9 chunks +12 lines, -81 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 9 chunks +12 lines, -77 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 10 chunks +12 lines, -79 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 2 9 chunks +12 lines, -82 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 9 chunks +12 lines, -82 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 2 9 chunks +12 lines, -81 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 2 8 chunks +11 lines, -81 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 9 chunks +12 lines, -80 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 2 3 10 chunks +12 lines, -79 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (15 generated)
adamk
3 years, 11 months ago (2017-01-05 19:06:45 UTC) #1
adamk
Actually, seems like we should remove all code for hole checks in full-codegen and AstGraphBuilder, ...
3 years, 11 months ago (2017-01-05 19:19:23 UTC) #4
adamk
This patch doesn't touch AstGraphBuilder, but removes all hole check logic from full-codegen.
3 years, 11 months ago (2017-01-05 19:48:49 UTC) #10
adamk
Okay, now it includes AstGraphBuilder too!
3 years, 11 months ago (2017-01-05 21:38:09 UTC) #16
Benedikt Meurer
Whoot! LGTM!
3 years, 11 months ago (2017-01-06 18:00:05 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615033002/60001
3 years, 11 months ago (2017-01-06 19:07:23 UTC) #19
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 19:45:12 UTC) #22
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/45c11887929c1f0fbc54849d2627cd8bb90...

Powered by Google App Engine
This is Rietveld 408576698