Improve error message for calling super() twice in a derived constructor

Improve error message for calling super() twice in a derived constructor

Previously the message was "this is not defined" which is nonsensical.

BUG=v8:4407
Review-Url: https://codereview.chromium.org/2614053002
Cr-Commit-Position: refs/heads/master@{#42114}
Committed: https://chromium.googlesource.com/v8/v8/+/0d726624004489f08566f526b05deb8fe9d1efc5

[adamk, 2017-01-05 22:01:38]

Description was changed from

==========
Improve error message for calling super() twice in a derived constructor

BUG=v8:4407
==========

to

==========
Improve error message for calling super() twice in a derived constructor

Previously the message was "this is not defined" which is nonsensical.

BUG=v8:4407
==========

[adamk, 2017-01-05 22:02:10]

adamk@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[adamk, 2017-01-05 22:04:43]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 22:04:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 22:22:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 22:22:57]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[adamk, 2017-01-05 23:24:02]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 23:24:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 23:50:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 23:50:24]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2017-01-06 11:02:03]

LGTM, thanks.

[adamk, 2017-01-06 19:47:49]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2017-01-06 19:47:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 19:49:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 19:49:57]

Failed to apply patch for src/messages.h:
While running git apply --index -p1;
  error: patch failed: src/messages.h:488
  error: src/messages.h: patch does not apply

Patch:       src/messages.h
Index: src/messages.h
diff --git a/src/messages.h b/src/messages.h
index
fb830075e912a09b45d52527c85f2cad3ce917bf..9947587b0f31ccf53f519b0e4166697a67650a61
100644
--- a/src/messages.h
+++ b/src/messages.h
@@ -488,6 +488,7 @@ class ErrorUtils : public AllStatic {
   /* ReferenceError */                                                        
\
   T(NonMethod, "'super' is referenced from non-method")                       
\
   T(NotDefined, "% is not defined")                                           
\
+  T(SuperAlreadyCalled, "Super constructor may only be called once")          
\
   T(UnsupportedSuper, "Unsupported reference to 'super'")                     
\
   /* RangeError */                                                            
\
   T(DateRange, "Provided date is not in valid range.")                        
\

[adamk, 2017-01-06 19:56:35]

The CQ bit was checked by adamk@chromium.org

[adamk, 2017-01-06 19:56:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/2614053002/#ps60001
(title: "Merged")

[commit-bot: I haz the power, 2017-01-06 19:56:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 20:26:03]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483732595561120,
"parent_rev": "a5f3c4d10c4d710a602c910083409ee6c2e84b38", "commit_rev":
"0d726624004489f08566f526b05deb8fe9d1efc5"}

[commit-bot: I haz the power, 2017-01-06 20:26:07]

Description was changed from

==========
Improve error message for calling super() twice in a derived constructor

Previously the message was "this is not defined" which is nonsensical.

BUG=v8:4407
==========

to

==========
Improve error message for calling super() twice in a derived constructor

Previously the message was "this is not defined" which is nonsensical.

BUG=v8:4407

Review-Url: https://codereview.chromium.org/2614053002
Cr-Commit-Position: refs/heads/master@{#42114}
Committed:
https://chromium.googlesource.com/v8/v8/+/0d726624004489f08566f526b05deb8fe9d...
==========

[commit-bot: I haz the power, 2017-01-06 20:26:08]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/0d726624004489f08566f526b05deb8fe9d...