Add UseCounters for navigator.vibrate usage compared to site engagement.

Add UseCounters for navigator.vibrate usage compared to site engagement.

These UseCounters will allow an investigation into how often
navigator.vibrate is called for sites with different engagement levels.

BUG=655415
Review-Url: https://codereview.chromium.org/2614913005
Cr-Commit-Position: refs/heads/master@{#441865}
Committed: https://chromium.googlesource.com/chromium/src/+/b4271bc30bd0c92be3fcf3c4cc92737edc55e7fb

[dominickn, 2017-01-06 00:43:51]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 00:44:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2017-01-06 00:44:49]

Description was changed from

==========
Add UseCounters for navigator.vibrate usage compared to site engagement.

These UseCounters will allow an investigation into how often
navigator.vibrate is called for sites with different engagement levels.

BUG=655415
==========

to

==========
Add UseCounters for navigator.vibrate usage compared to site engagement.

These UseCounters will allow an investigation into how often
navigator.vibrate is called for sites with different engagement levels.

BUG=655415
==========

[dominickn, 2017-01-06 00:44:49]

dominickn@chromium.org changed reviewers:
+ haraken@chromium.org, isherman@chromium.org

[dominickn, 2017-01-06 00:45:45]

haraken: PTAL at WebKit/

isherman: PTAL at histograms.xml

Thanks!

[haraken, 2017-01-06 00:56:27]

LGTM

https://codereview.chromium.org/2614913005/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp (right):

https://codereview.chromium.org/2614913005/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp:130: if
(level == mojom::blink::EngagementLevel::NONE)

Shall we use a switch statement?

[dominickn, 2017-01-06 01:38:11]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 01:38:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2017-01-06 01:38:35]

Thanks!

I just realised haraken@ is a reviewer for UseCounter additions to
histograms.xml, so -isherman as a reviewer.

https://codereview.chromium.org/2614913005/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp (right):

https://codereview.chromium.org/2614913005/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp:130: if
(level == mojom::blink::EngagementLevel::NONE)
On 2017/01/06 00:56:27, haraken wrote:
> 
> Shall we use a switch statement?

Done - though it's a bit more verbose as a result.

[dominickn, 2017-01-06 01:38:46]

dominickn@chromium.org changed reviewers:
- isherman@chromium.org

[dominickn, 2017-01-06 01:46:08]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 01:47:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 03:31:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 03:31:17]

Dry run: This issue passed the CQ dry run.

[dominickn, 2017-01-06 03:39:00]

The CQ bit was checked by dominickn@chromium.org

[dominickn, 2017-01-06 03:39:00]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2614913005/#ps20001
(title: "Address comment")

[commit-bot: I haz the power, 2017-01-06 03:39:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 03:43:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483673940566890,
"parent_rev": "98f40af6044a40ba8a10899efb11d75ab122dffd", "commit_rev":
"b4271bc30bd0c92be3fcf3c4cc92737edc55e7fb"}

[commit-bot: I haz the power, 2017-01-06 03:44:11]

Description was changed from

==========
Add UseCounters for navigator.vibrate usage compared to site engagement.

These UseCounters will allow an investigation into how often
navigator.vibrate is called for sites with different engagement levels.

BUG=655415
==========

to

==========
Add UseCounters for navigator.vibrate usage compared to site engagement.

These UseCounters will allow an investigation into how often
navigator.vibrate is called for sites with different engagement levels.

BUG=655415

Review-Url: https://codereview.chromium.org/2614913005
Cr-Commit-Position: refs/heads/master@{#441865}
Committed:
https://chromium.googlesource.com/chromium/src/+/b4271bc30bd0c92be3fcf3c4cc92...
==========

[commit-bot: I haz the power, 2017-01-06 03:44:12]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b4271bc30bd0c92be3fcf3c4cc92...