Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2610813006: Add UseCounters for alert(), confirm() and prompt() usage against site engagement. (Closed)

Created:
3 years, 11 months ago by dominickn
Modified:
3 years, 11 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, asvitkine+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UseCounters for alert(), confirm() and prompt() usage against site engagement. These UseCounters will allow an investigation into how often alert(), confirm(), and prompt() are called for sites with different engagement levels. BUG=644268 Review-Url: https://codereview.chromium.org/2610813006 Cr-Commit-Position: refs/heads/master@{#441875} Committed: https://chromium.googlesource.com/chromium/src/+/d6dfbbf145c5977edd5d53c056856286506a7434

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -0 lines) Patch
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 3 chunks +63 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +18 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +18 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
dominickn
PTAL, thanks!
3 years, 11 months ago (2017-01-06 02:39:44 UTC) #3
haraken
LGTM
3 years, 11 months ago (2017-01-06 02:47:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610813006/1
3 years, 11 months ago (2017-01-06 04:43:43 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 04:49:30 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d6dfbbf145c5977edd5d53c05685...

Powered by Google App Engine
This is Rietveld 408576698