Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2614883004:
[MD Settings] Fixes the crash when navigating directly to chrome://md-settings/signOut (Closed)
|
Created:
3 years, 11 months ago by Moe Modified:
3 years, 11 months ago Reviewers:
Dan Beam CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[MD Settings] Fixes the crash when navigating directly to chrome://md-settings/signOut
BUG=678548
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2614883004
Cr-Commit-Position: refs/heads/master@{#442118}
Committed: https://chromium.googlesource.com/chromium/src/+/005913147578ab11de32f536c7d7748df8f1d4bc
Patch Set 1 #Patch Set 2 : Added tests + another fix #Patch Set 3 : fixed cros tests #
Messages
Total messages: 28 (22 generated)
The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
mahmadi@chromium.org changed reviewers: + dbeam@chromium.org
Hi Dan, please review this CL.
lgtm but can haz test?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [MD Settings] Fixes the crash when navigating directly to chrome://md-settings/signOut BUG=678548 ========== to ========== [MD Settings] Fixes the crash when navigating directly to chrome://md-settings/signOut BUG=678548 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Added tests. also fixed another bug which I ran into: Since the profile deletion warning uses syncStatus data, profile stats count should be requested once the syncStatus is fetched.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run
Patchset #2 (id:20001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
lgtm
The CQ bit was checked by mahmadi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483749682954590,
"parent_rev": "d83aedbf719e5346d2de69a79b5a1d7e9b6c8462", "commit_rev":
"005913147578ab11de32f536c7d7748df8f1d4bc"}
Message was sent while issue was closed.
Description was changed from ========== [MD Settings] Fixes the crash when navigating directly to chrome://md-settings/signOut BUG=678548 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD Settings] Fixes the crash when navigating directly to chrome://md-settings/signOut BUG=678548 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2614883004 Cr-Commit-Position: refs/heads/master@{#442118} Committed: https://chromium.googlesource.com/chromium/src/+/005913147578ab11de32f536c7d7... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as https://chromium.googlesource.com/chromium/src/+/005913147578ab11de32f536c7d7... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
