Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: chrome/browser/resources/settings/people_page/people_page.js

Issue 2614883004: [MD Settings] Fixes the crash when navigating directly to chrome://md-settings/signOut (Closed)
Patch Set: fixed cros tests Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/settings/profile_info_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/people_page/people_page.js
diff --git a/chrome/browser/resources/settings/people_page/people_page.js b/chrome/browser/resources/settings/people_page/people_page.js
index 5698401c9806adf1293cdc77451f288973c87f53..6b6a2fe90df466c1407ae96deccc98ae80a30bc1 100644
--- a/chrome/browser/resources/settings/people_page/people_page.js
+++ b/chrome/browser/resources/settings/people_page/people_page.js
@@ -180,9 +180,6 @@ Polymer({
settings.getCurrentRoute() == settings.Route.IMPORT_DATA;
if (settings.getCurrentRoute() == settings.Route.SIGN_OUT) {
- // Request the latest profile stats count, but don't wait for it.
- settings.ProfileInfoBrowserProxyImpl.getInstance().getProfileStatsCount();
-
// If the sync status has not been fetched yet, optimistically display
// the disconnect dialog. There is another check when the sync status is
// fetched. The dialog will be closed then the user is not signed in.
@@ -250,6 +247,11 @@ Polymer({
if (!this.syncStatus && syncStatus && !syncStatus.signedIn)
chrome.metricsPrivate.recordUserAction('Signin_Impression_FromSettings');
+<if expr="not chromeos">
+ if (syncStatus.signedIn)
+ settings.ProfileInfoBrowserProxyImpl.getInstance().getProfileStatsCount();
+</if>
+
if (!syncStatus.signedIn && this.$.disconnectDialog.open)
this.$.disconnectDialog.close();
« no previous file with comments | « no previous file | chrome/browser/ui/webui/settings/profile_info_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698