Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2614843003: Remove mojo::edk::Init() from ARC unittest. (Closed)

Created:
3 years, 11 months ago by hidehiko
Modified:
3 years, 11 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, tzik, hidehiko+watch_chromium.org, nhiroki, lhchavez+watch_chromium.org, oshima+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org, hashimoto
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove mojo::edk::Init() from ARC unittest. Initialization of Mojo is handled by unittest framework. This CL removes it from SetUp() for ARC. BUG=672385 TEST=Ran unittest. Review-Url: https://codereview.chromium.org/2614843003 Cr-Commit-Position: refs/heads/master@{#441654} Committed: https://chromium.googlesource.com/chromium/src/+/76e8579476ef117b18cd323a370681deb7e17f00

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
hidehiko
PTAL. Please see details in the linked bug.
3 years, 11 months ago (2017-01-05 12:41:02 UTC) #6
Luis Héctor Chávez
lgtm
3 years, 11 months ago (2017-01-05 14:45:59 UTC) #7
Luis Héctor Chávez
lgtm
3 years, 11 months ago (2017-01-05 14:46:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614843003/1
3 years, 11 months ago (2017-01-05 14:46:22 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 14:50:12 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/76e8579476ef117b18cd323a3706...

Powered by Google App Engine
This is Rietveld 408576698