Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2617713002: [WIP] Add DCHECK for mojo::edk::Init().

Created:
3 years, 11 months ago by hidehiko
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add DCHECK for mojo::edk::Init(). mojo::edk::Init() initializes mojo::edk::internal::g_core, which is a raw pointer, so it should not be initialized twice otherwise the first instance will be leaked. This CL adds DCHECK for the case. BUG=672385 TEST=Ran bots.

Patch Set 1 #

Patch Set 2 : test #

Patch Set 3 : test #

Patch Set 4 : test #

Patch Set 5 : test #

Patch Set 6 : test #

Patch Set 7 : test #

Patch Set 8 : test #

Patch Set 9 : test #

Patch Set 10 : test #

Patch Set 11 : test #

Patch Set 12 : test #

Patch Set 13 : test #

Patch Set 14 : test #

Patch Set 15 : test #

Patch Set 16 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -56 lines) Patch
M chrome/service/service_process.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chromecast/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -2 lines 0 comments Download
M chromecast/app/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +25 lines, -0 lines 0 comments Download
M chromecast/app/DEPS View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +3 lines, -0 lines 0 comments Download
A chromecast/app/cast_browsertests_main.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +9 lines, -0 lines 0 comments Download
A chromecast/app/cast_test_launcher.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +12 lines, -0 lines 0 comments Download
M chromecast/app/cast_test_launcher.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +4 lines, -7 lines 0 comments Download
A chromecast/app/cast_unittests_main.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +15 lines, -0 lines 0 comments Download
M components/nacl/loader/nacl_helper_win_64.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +2 lines, -2 lines 0 comments Download
M components/nacl/loader/nacl_main.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/dom_storage/local_storage_context_mojo_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M mash/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
A mash/test/DEPS View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M mash/test/mash_unittests.cc View 1 2 3 4 5 6 7 1 chunk +7 lines, -0 lines 0 comments Download
M mojo/edk/embedder/embedder.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 5 chunks +21 lines, -12 lines 0 comments Download
M services/service_manager/background/tests/background_service_manager_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +3 lines, -1 line 0 comments Download
M services/service_manager/public/cpp/lib/service_test.cc View 1 2 3 4 5 6 2 chunks +6 lines, -3 lines 0 comments Download
M services/service_manager/public/cpp/service_test.h View 1 2 3 4 5 6 2 chunks +1 line, -2 lines 0 comments Download
M services/service_manager/public/cpp/test/BUILD.gn View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M services/service_manager/public/cpp/test/run_all_service_tests.cc View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
M services/service_manager/runner/host/service_process_launcher_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +0 lines, -22 lines 0 comments Download
M services/ui/common/BUILD.gn View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/common/run_all_service_tests.cc View 1 2 3 4 5 6 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 53 (53 generated)
hidehiko
The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-05 12:25:07 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617713002/1
3 years, 11 months ago (2017-01-05 12:25:25 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-05 13:08:36 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/297412)
3 years, 11 months ago (2017-01-05 13:08:36 UTC) #4
hidehiko
Description was changed from ========== Add DCHECK for mojo::edk::Init(). mojo::edk::Init() initializes mojo::edk::internal::g_core, which is a ...
3 years, 11 months ago (2017-01-05 15:30:43 UTC) #5
hidehiko
The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-06 07:14:39 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617713002/20001
3 years, 11 months ago (2017-01-06 07:14:50 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-06 07:57:50 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/298143)
3 years, 11 months ago (2017-01-06 07:57:50 UTC) #9
hidehiko
The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-06 08:43:22 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617713002/40001
3 years, 11 months ago (2017-01-06 08:43:34 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-06 08:47:07 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/286754) linux_chromium_asan_rel_ng on ...
3 years, 11 months ago (2017-01-06 08:47:07 UTC) #13
hidehiko
The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-06 13:23:01 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617713002/60001
3 years, 11 months ago (2017-01-06 13:23:15 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-06 14:11:11 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/298225)
3 years, 11 months ago (2017-01-06 14:11:12 UTC) #17
hidehiko
The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-06 15:01:06 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617713002/80001
3 years, 11 months ago (2017-01-06 15:01:33 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-06 15:12:01 UTC) #20
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/286858)
3 years, 11 months ago (2017-01-06 15:12:01 UTC) #21
hidehiko
The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-06 15:16:05 UTC) #22
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617713002/100001
3 years, 11 months ago (2017-01-06 15:16:34 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-06 15:53:21 UTC) #24
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/286864)
3 years, 11 months ago (2017-01-06 15:53:23 UTC) #25
hidehiko
The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-06 16:31:13 UTC) #26
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617713002/120001
3 years, 11 months ago (2017-01-06 16:31:51 UTC) #27
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-06 17:38:43 UTC) #28
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/298341)
3 years, 11 months ago (2017-01-06 17:38:44 UTC) #29
hidehiko
The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-12 09:41:50 UTC) #30
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617713002/140001
3 years, 11 months ago (2017-01-12 09:41:58 UTC) #31
hidehiko
The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-12 09:56:57 UTC) #32
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617713002/180001
3 years, 11 months ago (2017-01-12 09:57:12 UTC) #33
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-12 10:26:36 UTC) #34
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/290207)
3 years, 11 months ago (2017-01-12 10:26:37 UTC) #35
hidehiko
The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-12 10:53:01 UTC) #36
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617713002/200001
3 years, 11 months ago (2017-01-12 10:53:16 UTC) #37
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-12 11:23:13 UTC) #38
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/290217)
3 years, 11 months ago (2017-01-12 11:23:14 UTC) #39
hidehiko
The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-12 11:36:29 UTC) #40
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617713002/220001
3 years, 11 months ago (2017-01-12 11:36:38 UTC) #41
hidehiko
The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-12 12:51:40 UTC) #42
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617713002/260001
3 years, 11 months ago (2017-01-12 12:51:52 UTC) #43
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-12 13:39:30 UTC) #44
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/345454)
3 years, 11 months ago (2017-01-12 13:39:31 UTC) #45
hidehiko
The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-13 04:58:49 UTC) #46
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617713002/280001
3 years, 11 months ago (2017-01-13 04:59:09 UTC) #47
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-13 05:06:08 UTC) #48
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/290964)
3 years, 11 months ago (2017-01-13 05:06:08 UTC) #49
hidehiko
The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-13 05:14:34 UTC) #50
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2617713002/180002
3 years, 11 months ago (2017-01-13 05:14:55 UTC) #51
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-13 07:13:50 UTC) #52
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 07:13:50 UTC) #53 
Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Powered by Google App Engine
This is Rietveld 408576698