Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2614833002: DevTools: Do not show network pane on Timeline when there're no network activity (Closed)

Created:
3 years, 11 months ago by alph
Modified:
3 years, 11 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Do not show network pane on Timeline when there're no network activity BUG=675865 Committed: https://crrev.com/462577c210b4be14bc5b4ef594a8c9e8cab75ef2 Cr-Commit-Position: refs/heads/master@{#441580}

Patch Set 1 #

Patch Set 2 : tweak preferred height #

Total comments: 2

Patch Set 3 : addressing comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -7 lines) Patch
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js View 1 2 2 chunks +10 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineNetworkFlameChart.js View 1 3 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
alph
3 years, 11 months ago (2017-01-04 22:26:00 UTC) #2
pfeldman
lgtm https://codereview.chromium.org/2614833002/diff/20001/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js (right): https://codereview.chromium.org/2614833002/diff/20001/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js#newcode201 third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js:201: this._networkView.enableRuler(true); This is always enabled, no?
3 years, 11 months ago (2017-01-04 22:54:08 UTC) #3
alph
https://codereview.chromium.org/2614833002/diff/20001/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js (right): https://codereview.chromium.org/2614833002/diff/20001/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js#newcode201 third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js:201: this._networkView.enableRuler(true); On 2017/01/04 22:54:08, pfeldman wrote: > This is ...
3 years, 11 months ago (2017-01-04 23:14:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614833002/40001
3 years, 11 months ago (2017-01-05 01:27:50 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
3 years, 11 months ago (2017-01-05 04:13:25 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 04:16:31 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/462577c210b4be14bc5b4ef594a8c9e8cab75ef2
Cr-Commit-Position: refs/heads/master@{#441580}

Powered by Google App Engine
This is Rietveld 408576698