Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js

Issue 2614833002: DevTools: Do not show network pane on Timeline when there're no network activity (Closed)
Patch Set: addressing comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/timeline/TimelineNetworkFlameChart.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js
index c638759077aaaf2cad2dd4bcb25115734f08ee1e..2490fd5d00b4430681f9791a7d56d776e8221afe 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js
@@ -194,6 +194,14 @@ Timeline.TimelineFlameChartView = class extends UI.VBox {
this._mainView.scheduleUpdate();
this._networkDataProvider.reset();
+ if (this._networkDataProvider.isEmpty()) {
+ this._mainView.enableRuler(true);
+ this._splitWidget.hideSidebar();
+ } else {
+ this._mainView.enableRuler(false);
+ this._splitWidget.showBoth();
+ this.resizeToPreferredHeights();
+ }
this._networkView.scheduleUpdate();
}
@@ -295,7 +303,8 @@ Timeline.TimelineFlameChartView = class extends UI.VBox {
}
resizeToPreferredHeights() {
- this._splitWidget.setSidebarSize(this._networkDataProvider.preferredHeight() + this._splitResizer.clientHeight);
+ this._splitWidget.setSidebarSize(
+ this._networkDataProvider.preferredHeight() + this._splitResizer.clientHeight + UI.FlameChart.HeaderHeight + 2);
}
};
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/timeline/TimelineNetworkFlameChart.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698