[Devtools] Network group experiment is now grouped by connectionId

[Devtools] Network group experiment is now grouped by connectionId

This patch moves to using connectionId as the default for network
group experiment.

See: http://imgur.com/a/O7y52

R=dgozman
BUG=664704
Review-Url: https://codereview.chromium.org/2614823003
Cr-Commit-Position: refs/heads/master@{#444970}
Committed: https://chromium.googlesource.com/chromium/src/+/0b4be1946c9953f17157f063b43251e32394e193

[allada, 2017-01-05 01:51:21]

PTL

[allada, 2017-01-05 01:53:27]

Description was changed from

==========
[Devtools] Network group experiment is now grouped by connectionId

This patch moves to using connectionId as the default for network
group experiment.

R=dgozman
BUG=664704
==========

to

==========
[Devtools] Network group experiment is now grouped by connectionId

This patch moves to using connectionId as the default for network
group experiment.

See: http://imgur.com/a/O7y52

R=dgozman
BUG=664704
==========

[dgozman, 2017-01-10 00:50:28]

https://codereview.chromium.org/2614823003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(left):

https://codereview.chromium.org/2614823003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:794: if
(node[Network.NetworkLogView._isFilteredOutSymbol] !== isFilteredOut) {
Why change this?

https://codereview.chromium.org/2614823003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(right):

https://codereview.chromium.org/2614823003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:842:
group = new Network.NetworkGroupNode(this, request.url.asParsedURL().host + ' -
' + groupKey);
Don't forget to rebase and use .url() method.

[allada, 2017-01-19 01:31:31]

allada@chromium.org changed reviewers:
+ caseq@chromium.org, luoe@chromium.org

[allada, 2017-01-19 01:31:31]

PTaL

https://codereview.chromium.org/2614823003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(left):

https://codereview.chromium.org/2614823003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:794: if
(node[Network.NetworkLogView._isFilteredOutSymbol] !== isFilteredOut) {
On 2017/01/10 00:50:28, dgozman wrote:
> Why change this?

Because the parent may now change and we need to remove the item from the
current parent then add it back.

https://codereview.chromium.org/2614823003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(right):

https://codereview.chromium.org/2614823003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:842:
group = new Network.NetworkGroupNode(this, request.url.asParsedURL().host + ' -
' + groupKey);
On 2017/01/10 00:50:28, dgozman wrote:
> Don't forget to rebase and use .url() method.

Done.

[allada, 2017-01-19 23:19:54]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 23:20:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2017-01-20 00:22:40]

lgtm

https://codereview.chromium.org/2614823003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(right):

https://codereview.chromium.org/2614823003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:863:
group = new Network.NetworkGroupNode(this, request.url().asParsedURL().host + '
- ' + groupKey);
asParsedURL() can return null.

[allada, 2017-01-20 01:18:45]

The CQ bit was checked by allada@chromium.org

[allada, 2017-01-20 01:18:45]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2614823003/#ps80001
(title: "changes")

[commit-bot: I haz the power, 2017-01-20 01:19:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 03:48:01]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484875125051260,
"parent_rev": "4fc38e5c17890fe26add25f5efa16165d37709f9", "commit_rev":
"0b4be1946c9953f17157f063b43251e32394e193"}

[commit-bot: I haz the power, 2017-01-20 03:48:30]

Description was changed from

==========
[Devtools] Network group experiment is now grouped by connectionId

This patch moves to using connectionId as the default for network
group experiment.

See: http://imgur.com/a/O7y52

R=dgozman
BUG=664704
==========

to

==========
[Devtools] Network group experiment is now grouped by connectionId

This patch moves to using connectionId as the default for network
group experiment.

See: http://imgur.com/a/O7y52

R=dgozman
BUG=664704

Review-Url: https://codereview.chromium.org/2614823003
Cr-Commit-Position: refs/heads/master@{#444970}
Committed:
https://chromium.googlesource.com/chromium/src/+/0b4be1946c9953f17157f063b432...
==========

[commit-bot: I haz the power, 2017-01-20 03:48:32]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/0b4be1946c9953f17157f063b432...